From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751528AbZKKFlY (ORCPT ); Wed, 11 Nov 2009 00:41:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751257AbZKKFlX (ORCPT ); Wed, 11 Nov 2009 00:41:23 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:55782 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbZKKFlW (ORCPT ); Wed, 11 Nov 2009 00:41:22 -0500 Date: Tue, 10 Nov 2009 21:41:38 -0800 From: "Paul E. McKenney" To: Joe Perches Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu, linux-tip-commits@vger.kernel.org Subject: Re: [tip:core/rcu] rcu: Remove inline from forward-referenced functions Message-ID: <20091111054138.GA19777@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1257892710.25443.9.camel@Joe-Laptop.home> <20091110225926.GA8424@linux.vnet.ibm.com> <1257894380.25443.16.camel@Joe-Laptop.home> <20091110234101.GB8424@linux.vnet.ibm.com> <1257901421.25443.34.camel@Joe-Laptop.home> <20091111014222.GE8424@linux.vnet.ibm.com> <1257910108.25443.40.camel@Joe-Laptop.home> <20091111045013.GG8424@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091111045013.GG8424@linux.vnet.ibm.com> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2009 at 08:50:13PM -0800, Paul E. McKenney wrote: > On Tue, Nov 10, 2009 at 07:28:28PM -0800, Joe Perches wrote: > > On Tue, 2009-11-10 at 17:42 -0800, Paul E. McKenney wrote: > > > On Tue, Nov 10, 2009 at 05:03:41PM -0800, Joe Perches wrote: > > > > So maybe rename rcutree_plugin.h to rcutree_plugin.c and > > > > #include "rcutree_plugin.c" in rcutree.c instead. > > > Hmmm... > > > > Perhaps something like this: > > While I do very much appreciate your time and attention to this... > > My problem with this sort of thing is that when I tried it, it proved > fragile. Small changes required lots of rework of forward declarations. > Putting it at the end makes it work very nicely -- the list of forward > declarations doubles as documentation for the plugins, and the contents > of kernel/rcutree_plugin.h (or .c or whatever, either way I end up > violation about the same number of coding guidelines) is independent of > rearrangements of kernel/rcutree.c. > > The reason that I would really like to keep rcu_bootup_announce() as > a function is that it makes it trivial to collect RCU-flavor-dependent > boot-time information, if needed for some debugging effort. If I pull > the string out, this sort of thing becomes much more painful. And, as noted in our offline conversation, you are absolutely right that I need to add __init to both definitions of rcu_bootup_announce(), which I will do, with your Suggested-by. Fair enough? Thanx, Paul > > cheers, Joe > > > > rcu: rename rcutree_plugin.h to .c and use > > > > diff --git a/kernel/rcutree.c b/kernel/rcutree.c > > index d802419..737dc72 100644 > > --- a/kernel/rcutree.c > > +++ b/kernel/rcutree.c > > @@ -1783,6 +1783,8 @@ do { \ > > } \ > > } while (0) > > > > +#include "rcutree_plugin.c" > > + > > void __init __rcu_init(void) > > { > > rcu_bootup_announce(); > > @@ -1795,4 +1797,3 @@ void __init __rcu_init(void) > > open_softirq(RCU_SOFTIRQ, rcu_process_callbacks); > > } > > > > -#include "rcutree_plugin.h" > > diff --git a/kernel/rcutree.h b/kernel/rcutree.h > > index 17a28a0..ed11d16 100644 > > --- a/kernel/rcutree.h > > +++ b/kernel/rcutree.h > > @@ -300,8 +300,7 @@ DECLARE_PER_CPU(struct rcu_data, rcu_preempt_data); > > > > #else /* #ifdef RCU_TREE_NONCORE */ > > > > -/* Forward declarations for rcutree_plugin.h */ > > -static void rcu_bootup_announce(void); > > +/* Forward declarations for rcutree_plugin.c */ > > long rcu_batches_completed(void); > > static void rcu_preempt_note_context_switch(int cpu); > > static int rcu_preempted_readers(struct rcu_node *rnp); > > diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.c > > similarity index 99% > > rename from kernel/rcutree_plugin.h > > rename to kernel/rcutree_plugin.c > > index 52075da..5ca2d26 100644 > > --- a/kernel/rcutree_plugin.h > > +++ b/kernel/rcutree_plugin.c > > @@ -33,7 +33,7 @@ DEFINE_PER_CPU(struct rcu_data, rcu_preempt_data); > > /* > > * Tell them what RCU they are running. > > */ > > -static void rcu_bootup_announce(void) > > +static void __init rcu_bootup_announce(void) > > { > > printk(KERN_INFO > > "Experimental preemptable hierarchical RCU implementation.\n"); > > @@ -481,7 +481,7 @@ void exit_rcu(void) > > /* > > * Tell them what RCU they are running. > > */ > > -static void rcu_bootup_announce(void) > > +static void __init rcu_bootup_announce(void) > > { > > printk(KERN_INFO "Hierarchical RCU implementation.\n"); > > } > > > >