From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
x86@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] x86 VSDO: fix Kconfig help
Date: Wed, 11 Nov 2009 07:27:36 +0100 [thread overview]
Message-ID: <20091111062736.GA20546@elte.hu> (raw)
In-Reply-To: <4AF9FB6C.70003@oracle.com>
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> COMPAT_VDSO has 2 help text blocks, but kconfig only uses the
> last one found, so merge the 2 blocks.
>
> It would be real nice if kconfig would warn about this.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/x86/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-2632-rc6.orig/arch/x86/Kconfig
> +++ lnx-2632-rc6/arch/x86/Kconfig
> @@ -1601,12 +1601,12 @@ config COMPAT_VDSO
> prompt "Compat VDSO support"
> depends on X86_32 || IA32_EMULATION
> ---help---
> - Map the 32-bit VDSO to the predictable old-style address too.
> - ---help---
> Say N here if you are running a sufficiently recent glibc
> version (2.3.3 or later), to remove the high-mapped
> VDSO mapping and to exclusively use the randomized VDSO.
>
> + Map the 32-bit VDSO to the predictable old-style address too.
> +
> If unsure, say Y.
I've applied it with the original ordering of the lines - it makes more
sense that way. (first short summary of what the option does, then a
longer paragraph.)
Ingo
next prev parent reply other threads:[~2009-11-11 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 23:46 [PATCH] x86 VSDO: fix Kconfig help Randy Dunlap
2009-11-11 5:17 ` Américo Wang
2009-11-11 6:27 ` Ingo Molnar [this message]
2009-11-11 6:31 ` [tip:x86/urgent] x86 VSDO: Fix " tip-bot for Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111062736.GA20546@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox