From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757297AbZKKIdU (ORCPT ); Wed, 11 Nov 2009 03:33:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757213AbZKKIdT (ORCPT ); Wed, 11 Nov 2009 03:33:19 -0500 Received: from ozlabs.org ([203.10.76.45]:49884 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757038AbZKKIdS (ORCPT ); Wed, 11 Nov 2009 03:33:18 -0500 From: Rusty Russell To: Stephen Rothwell Subject: Re: linux-next: rr tree build failure Date: Wed, 11 Nov 2009 19:03:21 +1030 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; i686; ; ) Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, alan-jenkins@tuffmail.co.uk, x86@kernel.org References: <20091111140126.044be7d2.sfr@canb.auug.org.au> In-Reply-To: <20091111140126.044be7d2.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911111903.21923.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Nov 2009 01:31:26 pm Stephen Rothwell wrote: > Hi Rusty, > > Today's linux-next build (x86_64 allmodconfig) failed like this: > > .tmp_exports-asm.o: In function `__ksymtab_load_gs_index': > (__ksymtab_sorted+0x5b40): undefined reference to `load_gs_index' > > I have used the version of the rr tree from next-20091110 for today. It's inline and exported when CONFIG_PARAVIRT=y. Which is wrong. Here's the patch I've put in my series for tomorrow's linux-next: Subject: x86: don't export inline function For CONFIG_PARAVIRT, load_gs_index is an inline function (it's #defined to native_load_gs_index otherwise). Exporting an inline function breaks the new assembler-based alphabetical sorted symbol list: Today's linux-next build (x86_64 allmodconfig) failed like this: .tmp_exports-asm.o: In function `__ksymtab_load_gs_index': (__ksymtab_sorted+0x5b40): undefined reference to `load_gs_index' Signed-off-by: Rusty Russell To: x86@kernel.org Cc: alan-jenkins@tuffmail.co.uk diff --git a/arch/x86/kernel/x8664_ksyms_64.c b/arch/x86/kernel/x8664_ksyms_64.c --- a/arch/x86/kernel/x8664_ksyms_64.c +++ b/arch/x86/kernel/x8664_ksyms_64.c @@ -57,4 +57,6 @@ EXPORT_SYMBOL(__memcpy); EXPORT_SYMBOL(empty_zero_page); EXPORT_SYMBOL(init_level4_pgt); -EXPORT_SYMBOL(load_gs_index); +#ifndef CONFIG_PARAVIRT +EXPORT_SYMBOL(native_load_gs_index); +#endif