From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm@lists.linux-foundation.org, jbarnes@virtuousgeek.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
stern@rowland.harvard.edu, shaohua.li@intel.com,
bjorn.helgaas@hp.com
Subject: Re: [PATCH] pci: Updates to Rafael's runtime PCI PM patch set
Date: Wed, 11 Nov 2009 20:05:03 +0000 [thread overview]
Message-ID: <20091111200503.GA22328@srcf.ucam.org> (raw)
In-Reply-To: <200911112058.20331.rjw@sisk.pl>
On Wed, Nov 11, 2009 at 08:58:20PM +0100, Rafael J. Wysocki wrote:
> The PME was supposed to be turned on by pci_prepare_to_sleep().
> I guess it wasn't in practice?
Only if the device is set as a wakeup device, which seems messy. Though
there may need to be a check there to avoid duplicate PME setup.
> Generally, some parts of it belong to the
> "PCI PM: Run-time callbacks for PCI bus type" patch and the others belong
> to "PCI / ACPI PM: Platform support for PCI PME wake-up" patch. Should I fold
> the changes into them?
Feel free!
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-11-11 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 22:51 [RFC][PATCH 0/4] PCI run-time Power Management Rafael J. Wysocki
2009-10-08 22:52 ` [RFC][PATCH 1/4] PCI PM: Add function for checking PME status of devices Rafael J. Wysocki
2009-10-08 23:32 ` Bjorn Helgaas
2009-10-09 22:11 ` Rafael J. Wysocki
2009-10-08 22:53 ` [RFC][PATCH 2/4] PCI PM: PCIe PME root port service driver (rev. 3) Rafael J. Wysocki
2009-10-08 22:54 ` [RFC][PATCH 3/4] PCI / ACPI PM: Platform support for PCI PME wake-up (rev. 2) Rafael J. Wysocki
2009-10-09 11:23 ` Matthew Garrett
2009-10-09 23:05 ` Rafael J. Wysocki
2009-10-08 22:55 ` [RFC][PATCH 4/4] PCI PM: Run-time callbacks for PCI bus type Rafael J. Wysocki
2009-11-09 22:42 ` [PATCH] pci: Updates to Rafael's runtime PCI PM patch set Matthew Garrett
2009-11-11 19:58 ` Rafael J. Wysocki
2009-11-11 20:05 ` Matthew Garrett [this message]
2009-11-11 20:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111200503.GA22328@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox