* Fix argument order in memset call in ./drivers/media/common/ir-functions.c
@ 2009-11-11 21:59 Dave Jones
2009-11-12 7:09 ` Américo Wang
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2009-11-11 21:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: kraxel, Linux Kernel
Size is the third argument, not the second.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
index 655474b..abd4791 100644
--- a/drivers/media/common/ir-functions.c
+++ b/drivers/media/common/ir-functions.c
@@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
ir->ir_type = ir_type;
- memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
+ memset(ir->ir_codes, 0, sizeof(ir->ir_codes));
/*
* FIXME: This is a temporary workaround to use the new IR tables
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Fix argument order in memset call in ./drivers/media/common/ir-functions.c
2009-11-11 21:59 Fix argument order in memset call in ./drivers/media/common/ir-functions.c Dave Jones
@ 2009-11-12 7:09 ` Américo Wang
0 siblings, 0 replies; 2+ messages in thread
From: Américo Wang @ 2009-11-12 7:09 UTC (permalink / raw)
To: Dave Jones, Mauro Carvalho Chehab, kraxel, Linux Kernel
On Thu, Nov 12, 2009 at 5:59 AM, Dave Jones <davej@redhat.com> wrote:
> Size is the third argument, not the second.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Definitely yes.
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
> index 655474b..abd4791 100644
> --- a/drivers/media/common/ir-functions.c
> +++ b/drivers/media/common/ir-functions.c
> @@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
>
> ir->ir_type = ir_type;
>
> - memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
> + memset(ir->ir_codes, 0, sizeof(ir->ir_codes));
>
> /*
> * FIXME: This is a temporary workaround to use the new IR tables
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-12 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-11 21:59 Fix argument order in memset call in ./drivers/media/common/ir-functions.c Dave Jones
2009-11-12 7:09 ` Américo Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox