public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: akpm@linux-foundation.org, jens.axboe@oracle.com
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Mike Miller <mikem@beardog.cce.hp.com>,
	linux-kernel@vger.kernel.org,
	"Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Subject: [PATCH 0/2] Fix cciss/hpsa build errors
Date: Wed, 11 Nov 2009 17:25:07 -0700	[thread overview]
Message-ID: <20091112001933.5660.10843.stgit@bob.kio> (raw)

I recently tried to build mmotm, and configured both hpsa and cciss
as built-ins. I encountered the following build error since they
both export device attrs with the same name:

	drivers/scsi/built-in.o: multiple definition of `dev_attr_lunid'
	drivers/block/built-in.o: first defined here

The cciss patch seems obviously correct to me and would be appropriate
for the next .32-rc. But it's not critical, so if Jens wants to hold off
until next merge window, I'm fine with that.

The hpsa patch applies against mmotm. I haven't peeked at James's tree
to see if he's carrying hpsa, but my guess is "probably not". In that
case, I'm hoping Andrew can carry it until hpsa gets merged.

Thanks,
/ac

---

Alex Chiang (2):
      cciss: make device attrs static
      hpsa: make device attrs static


 drivers/block/cciss.c |   16 ++++++++--------
 drivers/scsi/hpsa.c   |    8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)


             reply	other threads:[~2009-11-12  0:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12  0:25 Alex Chiang [this message]
2009-11-12  0:25 ` [PATCH 1/2] cciss: make device attrs static Alex Chiang
2009-11-12  0:25 ` [PATCH 2/2] hpsa: " Alex Chiang
2009-11-12  1:12   ` Alex Chiang
2009-11-12 13:56     ` scameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091112001933.5660.10843.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikem@beardog.cce.hp.com \
    --cc=scameron@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox