Re: [PATCH] Devices that ignore USB spec generate invalid modaliases

[Greg KH <greg@kroah.com>]

On Wed, Nov 11, 2009 at 03:20:23AM -0500, Nathaniel McCallum wrote:
> Please CC me as I'm not subscribed to LKML.
> 
> The current code to generate usb modaliases from usb_device_id assumes 
> that the device's bcdDevice descriptor will actually be in BCD format. 
> While this should be a sane assumption, some devices don't follow spec 
> and just use plain old hex.  This causes drivers for these devices to 
> generate invalid modalias lines which will never actually match for the 
> hardware.
> 
> The following patch adds hex support for bcdDevice in file2alias.c. 
> Drivers for devices which have bcdDevice conforming to BCD will have no 
> change in modalias output.  Drivers for devices which don't conform 
> (primarily usb-storage and ibmcam in my initial survey) should now 
> generate valid modaliases.
> 
> EXAMPLE OUTPUT (ibmcam; space added to highlight change)
> Old: usb:v0545p800D d030[10-9] dc*dsc*dp*ic*isc*ip*
> New: usb:v0545p800D d030a      dc*dsc*dp*ic*isc*ip*

Huh?  The old one had '[]' in it?

What does the bcdDevice for this really look like in the device itself?
If it is messed up in the descriptor, then how can we know to fix it up
here?

And you might want to cc: linux-usb@vger.kernel.org with this as well,
as that's where the USB developers are.

thanks,

greg k-h