public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] Measuring term of acquiring spinlock
Date: Fri, 13 Nov 2009 11:51:27 +0100	[thread overview]
Message-ID: <20091113105126.GC5243@nowhere> (raw)
In-Reply-To: <20091113.132125.468378199533086916.mitake@dcl.info.waseda.ac.jp>

On Fri, Nov 13, 2009 at 01:21:25PM +0900, Hitoshi Mitake wrote:
> > Might make sense to put it into 'perf lock' kind of tool. I think 
> > Frederic had such plans.
> 
> If you want a tester for 'perf lock', please call me, Frederic :)


Thanks :)
I haven't started it yet, because of some other things I need to finish.

Would you be interested in starting it?

The lock tracepoints are:

- lock_acquire: the lock is requested but not yet "acquired"
- lock_release
- lock_contended: we can't get the lock yet because someone already
  holds it.
- lock_acquired: we got the lock


So, the point would be to develop a state machine that is
able to give us statistics on a per lock granularity
basis:


- the total/average/maximum time a lock is contended,
  waited before being acquired (probably
  lock_acquired time - lock_acquire time)

- the ratio of contention versus immediate availability
  => Sequence acquire - acquired means immediate
     availability. If we have a contended event inside
     it means it had to wait because of the contention.

- the total/average/maximum time a lock is held.
  It would be very nice to also add an option to see the
  callsites sorted from max to min, if possible with a per
  boundary granularity: the couple (lock callsite, unlock callsite),
  still on a per lock basis.

- any idea you could have...


Such a tool would be very useful to profile the kernel locking.

It would be nice to use design close to what perf sched does:
having an lock event structure that provides callbacks for each
lock events so that we can easily plug various plugin inside.

It's just a suggestion in case you are interested and have time
for that. Otherwise I'll do it later.

Hm?

Thanks,
	Frederic.


  parent reply	other threads:[~2009-11-13 10:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12  6:43 [PATCH][RFC] Measuring term of acquiring spinlock Hitoshi Mitake
2009-11-12  7:39 ` Ingo Molnar
2009-11-13  4:21   ` Hitoshi Mitake
2009-11-13  8:17     ` Ingo Molnar
2009-11-13  8:24       ` Peter Zijlstra
2009-11-13  8:40       ` Frederic Weisbecker
2009-11-13  8:51         ` Ingo Molnar
2009-11-13  9:06           ` [PATCH] tracing: Rename lockdep event subsystem into lock Frederic Weisbecker
2009-11-13  9:10             ` Peter Zijlstra
2009-11-13  9:26               ` Ingo Molnar
2009-11-13  9:36               ` Frederic Weisbecker
2009-11-13  9:31             ` [tip:perf/core] tracing: Rename 'lockdep' event subsystem into 'lock' tip-bot for Frederic Weisbecker
2009-11-13  9:57             ` tip-bot for Frederic Weisbecker
2009-11-13 10:51     ` Frederic Weisbecker [this message]
2009-11-15  1:20       ` [PATCH][RFC] Measuring term of acquiring spinlock Hitoshi Mitake
2009-11-15  2:21         ` Frederic Weisbecker
2009-11-15  8:38           ` Hitoshi Mitake
2009-12-07  3:34           ` [PATCH 1/2] Does raw_field_ptr() supports __data_loc? Hitoshi Mitake
2009-12-07  4:02             ` Frederic Weisbecker
2009-12-07 16:09             ` Steven Rostedt
2009-12-07  3:34           ` [PATCH 2/2] perf lock: New subcommand "lock" to perf for analyzing lock statistics Hitoshi Mitake
2009-12-07  4:41             ` Frederic Weisbecker
2009-12-07  7:27               ` Ingo Molnar
2009-12-07  8:38                 ` Xiao Guangrong
2009-12-07 15:00                   ` Hitoshi Mitake
2009-12-07 16:38                   ` Steven Rostedt
2009-12-07 19:48                   ` Frederic Weisbecker
2009-12-07 19:57                     ` Frederic Weisbecker
2009-12-08  1:31                     ` Xiao Guangrong
2009-12-07 14:57                 ` Hitoshi Mitake
2009-12-07 14:51               ` Hitoshi Mitake
2009-12-07 20:16                 ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113105126.GC5243@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox