From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc_dointvec,
Date: Sun, 15 Nov 2009 14:59:58 +0800 [thread overview]
Message-ID: <20091115065958.GA2459@hack> (raw)
In-Reply-To: <1258249925.16857.198.camel@Joe-Laptop.home>
On Sat, Nov 14, 2009 at 05:52:05PM -0800, Joe Perches wrote:
>Seems to be a typo.
>
Well, in this case, proc_dointvec == &proc_dointvec,
both of them are the same function pointer.
But yes, &proc_dointvec looks more readable.
>Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
>diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>index 0d949c5..d0bf4eb 100644
>--- a/kernel/sysctl.c
>+++ b/kernel/sysctl.c
>@@ -1605,7 +1605,7 @@ static struct ctl_table debug_table[] = {
> .data = &show_unhandled_signals,
> .maxlen = sizeof(int),
> .mode = 0644,
>- .proc_handler = proc_dointvec
>+ .proc_handler = &proc_dointvec,
> },
> #endif
> { .ctl_name = 0 }
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
next prev parent reply other threads:[~2009-11-15 6:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 1:52 [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc_dointvec, Joe Perches
2009-11-15 6:59 ` Américo Wang [this message]
2009-11-15 8:11 ` Ingo Molnar
2009-11-15 8:28 ` Joe Perches
2009-11-15 8:39 ` Ingo Molnar
2009-11-15 10:04 ` Eric W. Biederman
2009-11-15 10:33 ` Ingo Molnar
2009-11-15 12:29 ` Eric W. Biederman
2009-11-15 13:57 ` Ingo Molnar
2009-11-15 14:14 ` Eric W. Biederman
2009-11-15 17:31 ` Joe Perches
2009-11-15 18:20 ` Julia Lawall
2009-11-15 19:23 ` Joe Perches
2009-11-15 20:40 ` Julia Lawall
2009-11-15 20:53 ` Arnd Bergmann
2009-11-15 22:54 ` Julia Lawall
2009-11-15 21:13 ` Joe Perches
2009-11-15 21:34 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091115065958.GA2459@hack \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox