public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] Add -Wmissing-prototypes to HOSTCFLAGS; fix resulting warnings
@ 2009-11-16  0:37 Josh Triplett
  0 siblings, 0 replies; only message in thread
From: Josh Triplett @ 2009-11-16  0:37 UTC (permalink / raw)
  To: linux-kernel; +Cc: torvalds

In an effort to slow the continuous need for "make foo static" patches,
I'd like to work towards using GCC's -Wmissing-prototypes flag, which
generates a warning for any function not declared static or previously
prototyped.  This works much like Sparse's -Wdecl, though only for
functions, not variables.

As a start, I've fixed all such warnings that remain in host programs,
including generated code, and added -Wmissing-prototypes to HOSTCFLAGS
to try to keep it that way.  (Long-term, I think it may prove reasonable
to use -Werror=missing-prototypes.)

Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/josh/linux-misc hostprogs-wmissing-prototypes

As seen in the diffstat below, this represents almost exclusively
one-liner fixes, with the exception of the .c_shipped files generated by
flex/bison/gperf.  The diffstat for the corresponding input files
remains small.

I believe these changes seem sufficiently obvious to go into .32, and I
also think doing so would make it easier for any -Wmissing-prototypes
warnings in .33-targeted trees to get fixed before the next merge
window, rather than during the middle of it.

I've confirmed that this branch merges into current master cleanly, and
that no new warnings exist in current master.


The following changes since commit a3ccf63ee643ef243cbf8918da8b3f9238f10029:
  Linus Torvalds (1):
        Merge branch 'for-linus' of git://git.kernel.org/.../ieee1394/linux1394-2.6

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/josh/linux-misc hostprogs-wmissing-prototypes

Josh Triplett (12):
      kconfig: Make zconf.y work with current bison
      kconfig: Mark various internal functions static
      genksyms: Mark is_reserved_word static
      Documentation/vm/page-types.c: Declare checked_open static
      arch/alpha/boot/tools/objstrip.c: Mark "usage" static
      arch/powerpc/boot/addRamDisk.c: Mark several internal functions static
      arch/sparc/boot/*.c: Mark various internal functions static
      drm: radeon: Mark several functions static in mkregtable
      dtc: Set "noinput" in the lexer to avoid an unused function
      dtc: Mark various internal functions static
      oss: Mark loadhex static in hex2hex.c
      Makefile: Add -Wmising-prototypes to HOSTCFLAGS

 Documentation/vm/page-types.c        |    2 +-
 Makefile                             |    2 +-
 arch/alpha/boot/tools/objstrip.c     |    2 +-
 arch/powerpc/boot/addRamDisk.c       |    6 +-
 arch/sparc/boot/btfixupprep.c        |    8 +-
 arch/sparc/boot/piggyback_32.c       |   10 +-
 arch/sparc/boot/piggyback_64.c       |    2 +-
 drivers/gpu/drm/radeon/mkregtable.c  |   12 +-
 scripts/dtc/data.c                   |    2 +-
 scripts/dtc/dtc-lexer.l              |    2 +-
 scripts/dtc/dtc-lexer.lex.c_shipped  |   69 +++++--
 scripts/dtc/libfdt/fdt_ro.c          |    2 +-
 scripts/dtc/treesource.c             |    2 +-
 scripts/genksyms/keywords.c_shipped  |   95 +++++----
 scripts/genksyms/keywords.gperf      |    2 +
 scripts/kconfig/lex.zconf.c_shipped  |   25 ++-
 scripts/kconfig/zconf.gperf          |    2 +
 scripts/kconfig/zconf.hash.c_shipped |    2 +
 scripts/kconfig/zconf.l              |    6 +-
 scripts/kconfig/zconf.tab.c_shipped  |  379 +++++++++++++++------------------
 scripts/kconfig/zconf.y              |   13 +-
 sound/oss/hex2hex.c                  |    2 +-
 22 files changed, 338 insertions(+), 309 deletions(-)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-11-16  0:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-16  0:37 [GIT PULL] Add -Wmissing-prototypes to HOSTCFLAGS; fix resulting warnings Josh Triplett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox