Re: [PATCH 1/4] perf bench: Add new subsystem and new suite, bench/mem-memcpy.c

Ingo Molnar
2009-11-17T11:21:59Z

* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Subject: Re: [PATCH 1/4] perf bench: Add new subsystem and new suite, bench/mem-memcpy.c
> Date: Fri, 13 Nov 2009 10:46:50 +0100
>
> I've fixed mem-memcpy.c according to your comment,
> but I also have some comments.
>
> >
> > > +};
> > > +
> > > +struct routine routines[] = {
> > > + { "default",
> > > + memcpy,
> > > + "Default memcpy() provided by glibc" },
> > > + { NULL,
> > > + NULL,
> > > + NULL }
> >
> > { NULL, } would be equivalent i guess.
>
> Initializing the termination with { NULL, } causes build error.
> So I can't change this point.

ah, ok.

>
> > > + break;
> > > + case BENCH_FORMAT_SIMPLE:
> > > + if (use_clockcycle)
> > > + printf("%lf\n",
> > > + (double)clock_diff / (double)length);
> > > + else
> > > + printf("%lf\n", bps);
> > > + break;
> > > + default:
> > > + /* reaching here is something disaster */
> > > + fprintf(stderr, "Unknown format:%d\n", bench_format);
> >
> > could use pr_err() here i guess.
>
> It seems that pr_err() is a wrapper for printk(),
> so I can't use pr_err() in perf.

ok.

Ingo