public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Alex Chiang <achiang@hp.com>
Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Subject: Re: [PATCH 3/3] [CPUFREQ] make internal cpufreq_add_dev_* static
Date: Tue, 17 Nov 2009 19:29:03 -0500	[thread overview]
Message-ID: <20091118002903.GA14477@redhat.com> (raw)
In-Reply-To: <20091117221130.25933.92163.stgit@bob.kio>

On Tue, Nov 17, 2009 at 03:11:30PM -0700, Alex Chiang wrote:
 > No need to export these symbols; make them static.
 > 
 > 	cpufreq_add_dev_policy
 > 	cpufreq_add_dev_symlink
 > 	cpufreq_add_dev_interface
 > 
 > Signed-off-by: Alex Chiang <achiang@hp.com>
 
Ok. But can you move the parameters to the next line, so that
checkpatch doesn't whine ?

thanks.

	Dave


  reply	other threads:[~2009-11-18  1:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 22:11 [PATCH 0/3] cpufreq / linux-next build fixes Alex Chiang
2009-11-17 22:11 ` [PATCH 1/3] [CPUFREQ] make ACPI P-state cpufreq drivers depend on CONFIG_CPU_FREQ Alex Chiang
2009-11-18  0:08   ` Dave Jones
2009-11-18  4:17     ` Alex Chiang
2009-11-17 22:11 ` [PATCH 2/3] ACPI: do not define acpi_processor_get_bios_limit() in processor.h Alex Chiang
2009-11-18  0:09   ` Dave Jones
2009-11-19 11:31     ` [PATCH] ACPI: do not define acpi_processor_get_bios_limit() in processor.h (snd ver) Thomas Renninger
2009-11-19 18:08       ` Alex Chiang
2009-11-17 22:11 ` [PATCH 3/3] [CPUFREQ] make internal cpufreq_add_dev_* static Alex Chiang
2009-11-18  0:29   ` Dave Jones [this message]
2009-11-18  3:27     ` [PATCH v2] " Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118002903.GA14477@redhat.com \
    --to=davej@redhat.com \
    --cc=achiang@hp.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox