public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: <linux-fsdevel@vger.kernel.org>,
	Steven Whitehouse <swhiteho@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2)
Date: Wed, 18 Nov 2009 16:26:54 +0800	[thread overview]
Message-ID: <20091118082846.170413359@intel.com> (raw)
In-Reply-To: 20091118082648.140755818@intel.com

[-- Attachment #1: writeback-remove-congested-checks-linux_fs_gfs2_aops.patch --]
[-- Type: text/plain, Size: 1077 bytes --]

No one is calling wb_writeback and write_cache_pages with
wbc.nonblocking=1 any more. And lumpy pageout will want to do
nonblocking writeback without the congestion wait.

CC: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 fs/gfs2/aops.c |   10 ----------
 1 file changed, 10 deletions(-)

--- linux.orig/fs/gfs2/aops.c	2009-11-06 09:22:35.000000000 +0800
+++ linux/fs/gfs2/aops.c	2009-11-06 09:52:15.000000000 +0800
@@ -313,11 +313,6 @@ static int gfs2_write_jdata_pagevec(stru
 
 		if (ret || (--(wbc->nr_to_write) <= 0))
 			ret = 1;
-		if (wbc->nonblocking && bdi_write_congested(bdi)) {
-			wbc->encountered_congestion = 1;
-			ret = 1;
-		}
-
 	}
 	gfs2_trans_end(sdp);
 	return ret;
@@ -348,11 +343,6 @@ static int gfs2_write_cache_jdata(struct
 	int scanned = 0;
 	int range_whole = 0;
 
-	if (wbc->nonblocking && bdi_write_congested(bdi)) {
-		wbc->encountered_congestion = 1;
-		return 0;
-	}
-
 	pagevec_init(&pvec, 0);
 	if (wbc->range_cyclic) {
 		index = mapping->writeback_index; /* Start from prev offset */



  parent reply	other threads:[~2009-11-18  8:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18  8:26 [PATCH 00/12] trivial writeback cleanups/fixes Wu Fengguang
2009-11-18  8:26 ` [PATCH 01/12] writeback: remove unused nonblocking and congestion checks Wu Fengguang
2009-11-18  8:26 ` [PATCH 02/12] writeback: remove unused nonblocking and congestion checks (write_cache_pages) Wu Fengguang
2009-11-18  8:26 ` [PATCH 03/12] writeback: remove unused nonblocking and congestion checks (pohmelfs) Wu Fengguang
2009-11-19  8:11   ` Wu Fengguang
2009-11-19 11:04     ` Evgeniy Polyakov
2009-11-20  1:53       ` Wu Fengguang
2009-11-21 11:23         ` Evgeniy Polyakov
2009-11-18  8:26 ` [PATCH 04/12] writeback: remove unused nonblocking and congestion checks (afs) Wu Fengguang
2009-11-19  8:09   ` Wu Fengguang
2009-11-19 16:51     ` David Howells
2009-11-18  8:26 ` [PATCH 05/12] writeback: remove unused nonblocking and congestion checks (cifs) Wu Fengguang
2009-11-18  8:26 ` Wu Fengguang [this message]
2009-11-18  9:59   ` [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2) Steven Whitehouse
2009-11-18 10:09     ` Wu Fengguang
2009-11-18 11:13       ` Steven Whitehouse
2009-11-18  8:26 ` [PATCH 07/12] writeback: remove unused nonblocking and congestion checks (xfs) Wu Fengguang
2009-11-18 21:27   ` Dave Chinner
2009-11-19  8:05     ` Wu Fengguang
2009-11-20  7:24       ` Dave Chinner
2009-11-18  8:26 ` [PATCH 08/12] ext4: remove encountered_congestion trace Wu Fengguang
2009-11-24 16:18   ` tytso
2009-11-18  8:26 ` [PATCH 09/12] ext4: remove unused parameter wbc from __ext4_journalled_writepage() Wu Fengguang
2009-11-24 16:18   ` tytso
2009-11-18  8:26 ` [PATCH 10/12] writeback: remove the always false bdi_cap_writeback_dirty() test Wu Fengguang
2009-11-18  8:26 ` [PATCH 11/12] writeback: introduce wbc.for_background Wu Fengguang
2009-11-18  8:27 ` [PATCH 12/12] bdi: use bdi_stat_sum() for more accurate debugfs stats Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118082846.170413359@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox