From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: <linux-fsdevel@vger.kernel.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 11/12] writeback: introduce wbc.for_background
Date: Wed, 18 Nov 2009 16:26:59 +0800 [thread overview]
Message-ID: <20091118082846.790387883@intel.com> (raw)
In-Reply-To: 20091118082648.140755818@intel.com
[-- Attachment #1: writeback-add-wbc-for_background.patch --]
[-- Type: text/plain, Size: 1728 bytes --]
It will lower the flush priority for NFS, and maybe more in future.
CC: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
fs/fs-writeback.c | 1 +
fs/nfs/write.c | 2 +-
include/linux/writeback.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
--- linux.orig/fs/fs-writeback.c 2009-11-18 16:26:04.000000000 +0800
+++ linux/fs/fs-writeback.c 2009-11-18 16:26:07.000000000 +0800
@@ -713,6 +713,7 @@ static long wb_writeback(struct bdi_writ
.sync_mode = args->sync_mode,
.older_than_this = NULL,
.for_kupdate = args->for_kupdate,
+ .for_background = args->for_background,
.range_cyclic = args->range_cyclic,
};
unsigned long oldest_jif;
--- linux.orig/include/linux/writeback.h 2009-11-18 16:25:28.000000000 +0800
+++ linux/include/linux/writeback.h 2009-11-18 16:26:07.000000000 +0800
@@ -76,6 +76,7 @@ struct writeback_control {
unsigned nonblocking:1; /* Don't get stuck on request queues */
unsigned encountered_congestion:1; /* An output: a queue is full */
unsigned for_kupdate:1; /* A kupdate writeback */
+ unsigned for_background:1; /* A background writeback */
unsigned for_reclaim:1; /* Invoked from the page allocator */
unsigned range_cyclic:1; /* range_start is cyclic */
unsigned more_io:1; /* more io to be dispatched */
--- linux.orig/fs/nfs/write.c 2009-11-18 16:25:28.000000000 +0800
+++ linux/fs/nfs/write.c 2009-11-18 16:26:07.000000000 +0800
@@ -178,7 +178,7 @@ static int wb_priority(struct writeback_
{
if (wbc->for_reclaim)
return FLUSH_HIGHPRI | FLUSH_STABLE;
- if (wbc->for_kupdate)
+ if (wbc->for_kupdate || wbc->for_background)
return FLUSH_LOWPRI;
return 0;
}
next prev parent reply other threads:[~2009-11-18 8:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 8:26 [PATCH 00/12] trivial writeback cleanups/fixes Wu Fengguang
2009-11-18 8:26 ` [PATCH 01/12] writeback: remove unused nonblocking and congestion checks Wu Fengguang
2009-11-18 8:26 ` [PATCH 02/12] writeback: remove unused nonblocking and congestion checks (write_cache_pages) Wu Fengguang
2009-11-18 8:26 ` [PATCH 03/12] writeback: remove unused nonblocking and congestion checks (pohmelfs) Wu Fengguang
2009-11-19 8:11 ` Wu Fengguang
2009-11-19 11:04 ` Evgeniy Polyakov
2009-11-20 1:53 ` Wu Fengguang
2009-11-21 11:23 ` Evgeniy Polyakov
2009-11-18 8:26 ` [PATCH 04/12] writeback: remove unused nonblocking and congestion checks (afs) Wu Fengguang
2009-11-19 8:09 ` Wu Fengguang
2009-11-19 16:51 ` David Howells
2009-11-18 8:26 ` [PATCH 05/12] writeback: remove unused nonblocking and congestion checks (cifs) Wu Fengguang
2009-11-18 8:26 ` [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2) Wu Fengguang
2009-11-18 9:59 ` Steven Whitehouse
2009-11-18 10:09 ` Wu Fengguang
2009-11-18 11:13 ` Steven Whitehouse
2009-11-18 8:26 ` [PATCH 07/12] writeback: remove unused nonblocking and congestion checks (xfs) Wu Fengguang
2009-11-18 21:27 ` Dave Chinner
2009-11-19 8:05 ` Wu Fengguang
2009-11-20 7:24 ` Dave Chinner
2009-11-18 8:26 ` [PATCH 08/12] ext4: remove encountered_congestion trace Wu Fengguang
2009-11-24 16:18 ` tytso
2009-11-18 8:26 ` [PATCH 09/12] ext4: remove unused parameter wbc from __ext4_journalled_writepage() Wu Fengguang
2009-11-24 16:18 ` tytso
2009-11-18 8:26 ` [PATCH 10/12] writeback: remove the always false bdi_cap_writeback_dirty() test Wu Fengguang
2009-11-18 8:26 ` Wu Fengguang [this message]
2009-11-18 8:27 ` [PATCH 12/12] bdi: use bdi_stat_sum() for more accurate debugfs stats Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118082846.790387883@intel.com \
--to=fengguang.wu@intel.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox