* 2.6.32-rc7: compile regression on spitz
@ 2009-11-18 9:01 Pavel Machek
2009-11-18 14:38 ` Stanislav Brabec
2009-11-21 23:46 ` Pavel Machek
0 siblings, 2 replies; 4+ messages in thread
From: Pavel Machek @ 2009-11-18 9:01 UTC (permalink / raw)
To: rpurdie, lenz, kernel list, Dirk, arminlitzel, Cyril Hrubis,
thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao,
utx, Rafael J. Wysocki
If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
rc5. Fix is one more ifdef...
Signed-off-by: Pavel Machek <pavel@ucw.cz>
--- a/arch/arm/mach-pxa/spitz.c 2009-11-17 17:10:21.000000000 +0100
+++ b/arch/arm/mach-pxa/spitz.c 2009-11-18 05:55:21.000000000 +0100
@@ -802,10 +802,12 @@
{
spitz_ficp_platform_data.gpio_pwdown = SPITZ_GPIO_IR_ON;
+#ifdef CONFIG_MACH_BORZOI
if (machine_is_borzoi()) {
sharpsl_nand_platform_data.badblock_pattern = &sharpsl_akita_bbt;
sharpsl_nand_platform_data.ecc_layout = &akita_oobinfo;
}
+#endif
platform_scoop_config = &spitz_pcmcia_config;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.32-rc7: compile regression on spitz
2009-11-18 9:01 2.6.32-rc7: compile regression on spitz Pavel Machek
@ 2009-11-18 14:38 ` Stanislav Brabec
2009-11-22 15:33 ` Eric Miao
2009-11-21 23:46 ` Pavel Machek
1 sibling, 1 reply; 4+ messages in thread
From: Stanislav Brabec @ 2009-11-18 14:38 UTC (permalink / raw)
To: Pavel Machek
Cc: rpurdie, lenz, kernel list, Dirk, arminlitzel, Cyril Hrubis,
thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao,
Rafael J. Wysocki
Pavel Machek wrote:
> If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
> rc5. Fix is one more ifdef...
That was my mistake in 5e0fa3f.
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Stanislav Brabec <utx@penguin.cz>
--
Stanislav Brabec
http://www.penguin.cz/~utx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.32-rc7: compile regression on spitz
2009-11-18 9:01 2.6.32-rc7: compile regression on spitz Pavel Machek
2009-11-18 14:38 ` Stanislav Brabec
@ 2009-11-21 23:46 ` Pavel Machek
1 sibling, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2009-11-21 23:46 UTC (permalink / raw)
To: rpurdie, lenz, kernel list, Dirk, arminlitzel, Cyril Hrubis,
thommycheck, linux-arm-kernel, dbaryshkov, omegamoon, eric.y.miao,
utx, Rafael J. Wysocki
On Wed 2009-11-18 10:01:00, Pavel Machek wrote:
>
> If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
> rc5. Fix is one more ifdef...
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Eric, this being after-rc5 regression... it would be nice to actually
fix it for final...
Pavel
> --- a/arch/arm/mach-pxa/spitz.c 2009-11-17 17:10:21.000000000 +0100
> +++ b/arch/arm/mach-pxa/spitz.c 2009-11-18 05:55:21.000000000 +0100
> @@ -802,10 +802,12 @@
> {
> spitz_ficp_platform_data.gpio_pwdown = SPITZ_GPIO_IR_ON;
>
> +#ifdef CONFIG_MACH_BORZOI
> if (machine_is_borzoi()) {
> sharpsl_nand_platform_data.badblock_pattern = &sharpsl_akita_bbt;
> sharpsl_nand_platform_data.ecc_layout = &akita_oobinfo;
> }
> +#endif
>
> platform_scoop_config = &spitz_pcmcia_config;
>
>
>
>
>
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.32-rc7: compile regression on spitz
2009-11-18 14:38 ` Stanislav Brabec
@ 2009-11-22 15:33 ` Eric Miao
0 siblings, 0 replies; 4+ messages in thread
From: Eric Miao @ 2009-11-22 15:33 UTC (permalink / raw)
To: Stanislav Brabec
Cc: Pavel Machek, rpurdie, lenz, kernel list, Dirk, arminlitzel,
Cyril Hrubis, thommycheck, linux-arm-kernel, dbaryshkov,
omegamoon, Rafael J. Wysocki
2009/11/18 Stanislav Brabec <utx@penguin.cz>:
> Pavel Machek wrote:
>> If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
>> rc5. Fix is one more ifdef...
>
> That was my mistake in 5e0fa3f.
>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> Acked-by: Stanislav Brabec <utx@penguin.cz>
>
Applied to 'fix'.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-22 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 9:01 2.6.32-rc7: compile regression on spitz Pavel Machek
2009-11-18 14:38 ` Stanislav Brabec
2009-11-22 15:33 ` Eric Miao
2009-11-21 23:46 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox