Re: [PATCH 1/2] BKL: Remove BKL from default_llseek()

Jamie Lokier
2009-11-19T02:40:24Z

Alan Cox wrote:
> O> But nowadays, even that doesn't happen. sys_read() and sys_write()
> > make a copy of f_pos using file_pos_read(), so drivers cannot see the
> > value change during the call - except for their own change.
> >
> > I find myself wondering why the VFS isn't responsible for the position
> > update instead of the driver... Would it be a valid cleanup to move
> > it from the driver to VFS?
>
> And how would you adjust it. Not all devices have a bytes read == offset
> relationship. The VFS doesn't know enough.

That was implicit in my question: Are there any seekable devices where
bytes read != offset delta, and if yes, is that correct behaviour, a
bug, or a silly interface that should go away?

-- Jamie