From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Roland McGrath <roland@redhat.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Mike Galbraith" <efault@gmx.de>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH 3/4] perf symbols: Record the build_ids of kernel modules too
Date: Wed, 18 Nov 2009 20:33:41 -0200 [thread overview]
Message-ID: <20091118223341.GC14014@ghostprotocols.net> (raw)
In-Reply-To: <20091118222910.8F6F51983@magilla.sf.frob.com>
Em Wed, Nov 18, 2009 at 02:29:10PM -0800, Roland McGrath escreveu:
> > + snprintf(name, sizeof(name),
> > + "/sys/module/%s/notes/.note.gnu.build-id", line);
>
> The arch linker script for .ko's is free to fold notes into a single
> section with a different name or suchlike, and maybe future ones will. So
> it's not pedantically kosher to assume the name of the section rather than
> just looking at all the /sys/module/%s/notes/* files present until you find
> NT_GNU_BUILD_ID. (In practice there is probably only ever one file there
> to look at, but you never know.)
Ahah! That seems to explain why the kernel one is "notes" while the
modules's are ".note.gnu.build-id"! I'll cook a super-dupa-careful
cooker follow on patch to get that right, thanks again!
- Arnaldo
prev parent reply other threads:[~2009-11-18 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 22:20 [PATCH 1/4] perf symbols: Fix comparision of build_ids Arnaldo Carvalho de Melo
2009-11-18 22:20 ` [PATCH 2/4] perf symbols: Kill struct build_id_list and die() another day Arnaldo Carvalho de Melo
2009-11-18 22:20 ` [PATCH 3/4] perf symbols: Record the build_ids of kernel modules too Arnaldo Carvalho de Melo
2009-11-18 22:20 ` [PATCH 4/4] perf symbols: Capture the running kernel buildid too Arnaldo Carvalho de Melo
2009-11-18 22:29 ` Arnaldo Carvalho de Melo
2009-11-18 22:29 ` [PATCH 3/4] perf symbols: Record the build_ids of kernel modules too Roland McGrath
2009-11-18 22:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118223341.GC14014@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox