Re: [PATCH 1/3] [CPUFREQ] make ACPI P-state cpufreq drivers depend on CONFIG_CPU_FREQ

Dave Jones
2009-11-18T04:13:24Z

> diff --git a/arch/x86/kernel/cpu/cpufreq/Kconfig b/arch/x86/kernel/cpu/cpufreq/Kconfig
> index f138c6c..ca40a9f 100644
> --- a/arch/x86/kernel/cpu/cpufreq/Kconfig
> +++ b/arch/x86/kernel/cpu/cpufreq/Kconfig
> @@ -13,7 +13,7 @@ comment "CPUFreq processor drivers"
> config X86_ACPI_CPUFREQ
> tristate "ACPI Processor P-States driver"
> select CPU_FREQ_TABLE
> - depends on ACPI_PROCESSOR
> + depends on ACPI_PROCESSOR && CPU_FREQ
> help
> This driver adds a CPUFreq driver which utilizes the ACPI
> Processor Performance States.
> @@ -69,7 +69,7 @@ config X86_POWERNOW_K6
> config X86_POWERNOW_K7
> tristate "AMD Mobile Athlon/Duron PowerNow!"
> select CPU_FREQ_TABLE
> - depends on X86_32
> + depends on X86_32 && CPU_FREQ
> help
> This adds the CPUFreq driver for mobile AMD K7 mobile processors.
>
> @@ -87,7 +87,7 @@ config X86_POWERNOW_K7_ACPI
> config X86_POWERNOW_K8
> tristate "AMD Opteron/Athlon64 PowerNow!"
> select CPU_FREQ_TABLE
> - depends on ACPI && ACPI_PROCESSOR
> + depends on ACPI && ACPI_PROCESSOR && CPU_FREQ
> help
> This adds the CPUFreq driver for K8/K10 Opteron/Athlon64 processors.

This doesn't make sense, as this whole file is guarded with

if CPU_FREQ
...
endif

The dependancy has to be true, or you wouldn't ever see these options.

Dave