Re: [PATCH 2/5] pata_sis: Implement MWDMA for the UDMA 133 capable chips

Alan Cox
2009-11-17T17:36:30Z

> > +static int mwdma_clip_to_pio(struct ata_device *adev)
> > +{
> > + const int mwdma_to_pio[3] = {
> > + XFER_PIO_0, XFER_PIO_3, XFER_PIO_4
> > + };
> > + return min(mwdma_to_pio[adev->dma_mode - XFER_MW_DMA_0],
> > + adev->pio_mode - XFER_PIO_0);
> > +}
>
> This wants to be in the generic libata code.

I'm not convinced because for the majority of drivers the libata timing
interface handles it. SiS needs it just because it does things by
precomputed tables. It's a one off interface.

Alan