Re: [PATCH 4/5] pata: Update experimental tags

Bartlomiej Zolnierkiewicz
2009-11-18T19:17:20Z

On Wednesday 18 November 2009 19:47:25 Sergei Shtylyov wrote:
> Hello.
>
> Alan Cox wrote:
>
> >>Having separate drivers wasn't the best decisions from the maintainability
> >>point-of-view. It added needless complexity (different chips share the same
>
> > It was most definitely a good decision, having maintained both sets of
>
> Separating HPT36x was grounded enough decision but I can't say the same
> of the separation of HPT3xxN.

When it comes to HPT36x I would agree if we would be developing completely
from scratch but due to historical reasons we share UDMA blacklists between
HPT36x and HPT37x. It is not worth it in terms of potential regressions to
try to untangle them nowadays.

> > drivers at different times. It also makes it possible to do things the
> > way highpoint does
>
> Oh, don't remind me of that stupid code mostly not worth copying from...
>
> >>PCI IDs which make detection across multiple drivers extremely painful) and
> >>confusion (i.e. would you have guessed that HPT302 is supported by pata_hpt37x
> >>while HPT302N by pata_hpt3x2n?).
>
> How about HPT371N? ;-)

Not a problem, this one is unsupported according to help entries. ;)

--
Bartlomiej Zolnierkiewicz