Re: [PATCH 4/5] pata: Update experimental tags

Bartlomiej Zolnierkiewicz
2009-11-18T18:21:10Z

On Tuesday 17 November 2009 15:51:39 Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/ata/Kconfig | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index f2df6e2..36931e0 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -374,7 +374,7 @@ config PATA_HPT366
> If unsure, say N.
>
> config PATA_HPT37X
> - tristate "HPT 370/370A/371/372/374/302 PATA support (Experimental)"
> + tristate "HPT 370/370A/371/372/374/302 PATA support"
> depends on PCI && EXPERIMENTAL
> help
> This option enables support for the majority of the later HPT
> @@ -383,7 +383,7 @@ config PATA_HPT37X
> If unsure, say N.
>
> config PATA_HPT3X2N
> - tristate "HPT 372N/302N PATA support (Experimental)"
> + tristate "HPT 372N/302N PATA support"
> depends on PCI && EXPERIMENTAL
> help
> This option enables support for the N variant HPT PATA

Maybe they are 'stable' but when it comes to features they are behind hpt366
(i.e. they lack PCI PM), which is also much cleaner than your drivers, easier
to understand and much smaller..

1609 drivers/ide/hpt366.c

432 drivers/ata/pata_hpt366.c
1041 drivers/ata/pata_hpt37x.c
594 drivers/ata/pata_hpt3x2n.c
2067 total

(we can still easily cut more than 100 LOC from hpt366)

Having separate drivers wasn't the best decisions from the maintainability
point-of-view. It added needless complexity (different chips share the same
PCI IDs which make detection across multiple drivers extremely painful) and
confusion (i.e. would you have guessed that HPT302 is supported by pata_hpt37x
while HPT302N by pata_hpt3x2n?).

--
Bartlomiej Zolnierkiewicz