Re: [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2)

Steven Whitehouse
2009-11-18T11:11:28Z

Hi,

On Wed, 2009-11-18 at 18:09 +0800, Wu Fengguang wrote:
> Hi Steven,
>
> On Wed, Nov 18, 2009 at 05:59:46PM +0800, Steven Whitehouse wrote:
> > Hi,
> >
> > That looks ok to me, modulo the warnings below. The only "non-obvious"
> > thing in this area which the GFS2 writepage[s] code relies upon is the
> > assumption that if we have a ->writepages() then ->writepage() will
> > never be called from a context which requires the fs to actually do a
> > write (i.e. the fs can refuse this if required). That is also only the
> > case for journaled data files - normal writes don't have that
> > requirement.
>
> Thank you for the tips. I don't think pageout() or migration
> writeout() has that hard expectation for ->writepage() :)
>
> > CC [M] fs/gfs2/aops.o
> > fs/gfs2/aops.c: In function ‘gfs2_write_jdata_pagevec’:
> > fs/gfs2/aops.c:272: warning: unused variable ‘bdi’
> > fs/gfs2/aops.c: In function ‘gfs2_write_cache_jdata’:
> > fs/gfs2/aops.c:336: warning: unused variable ‘bdi’
>
> Ah sorry!
>
> > Once the warnings are fixed:
> >
> > Acked-by: Steven Whitehouse <swhiteho@redhat.com>
> >
> > Do you want me to add this patch into my tree, or were you planning to
> > submit via a different tree?
>
> Thanks, can you pull the updated patch directly to your tree?
>
Yes, its in my -nmw tree now. Thanks,

Steve.