From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: Implement gpio_to_irq() for wm831x
Date: Fri, 20 Nov 2009 10:22:15 +0100 [thread overview]
Message-ID: <20091120092214.GB3733@sortiz.org> (raw)
In-Reply-To: <1258392116-31973-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Mon, Nov 16, 2009 at 05:21:56PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
I'm taking this one, unless David wants to do it otherwise.
Cheers,
Samuel.
> ---
> drivers/gpio/wm831x-gpio.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/wm831x-gpio.c b/drivers/gpio/wm831x-gpio.c
> index f5e4934..b4468b6 100644
> --- a/drivers/gpio/wm831x-gpio.c
> +++ b/drivers/gpio/wm831x-gpio.c
> @@ -22,6 +22,7 @@
> #include <linux/mfd/wm831x/core.h>
> #include <linux/mfd/wm831x/pdata.h>
> #include <linux/mfd/wm831x/gpio.h>
> +#include <linux/mfd/wm831x/irq.h>
>
> struct wm831x_gpio {
> struct wm831x *wm831x;
> @@ -78,6 +79,17 @@ static void wm831x_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> value << offset);
> }
>
> +static int wm831x_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
> +{
> + struct wm831x_gpio *wm831x_gpio = to_wm831x_gpio(chip);
> + struct wm831x *wm831x = wm831x_gpio->wm831x;
> +
> + if (!wm831x->irq_base)
> + return -EINVAL;
> +
> + return wm831x->irq_base + WM831X_IRQ_GPIO_1 + offset;
> +}
> +
> #ifdef CONFIG_DEBUG_FS
> static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> {
> @@ -173,6 +185,7 @@ static struct gpio_chip template_chip = {
> .get = wm831x_gpio_get,
> .direction_output = wm831x_gpio_direction_out,
> .set = wm831x_gpio_set,
> + .to_irq = wm831x_gpio_to_irq,
> .dbg_show = wm831x_gpio_dbg_show,
> .can_sleep = 1,
> };
> --
> 1.6.5.2
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2009-11-20 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 17:21 [PATCH] gpiolib: Implement gpio_to_irq() for wm831x Mark Brown
2009-11-20 9:22 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120092214.GB3733@sortiz.org \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox