public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Serge Belyshev <belyshev@depni.sinp.msu.ru>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v2] k10temp: temperature sensor for AMD Family  10h/11h CPUs
Date: Fri, 20 Nov 2009 12:30:16 +0100	[thread overview]
Message-ID: <20091120123016.19d98ab4@hyperion.delvare> (raw)
In-Reply-To: <4B0673D7.5010006@ladisch.de>

On Fri, 20 Nov 2009 11:47:51 +0100, Clemens Ladisch wrote:
> This adds a driver for the internal temperature sensor of AMD Family 10h
> and 11h CPUs.
> 
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> v2: Erratum 319 now results in a warning, not an error, because it cannot
>     be reliably detected; Serge Belyshev reports that his CPU sensor works.

Nack. Unreliable sensors -> the default must be to NOT bind to these
CPUs. Feel free to provide a way to force the bind to happen (and still
print a big fat warning that this is a very bad idea), but do NOT make
it the default. Otherwise your driver will _never_ make it into the
kernel tree.

As a side note I'd be curious to see what Serge calls "working
sensors". We had several reports in the past of people who claimed that
their sensors were working. After looking at their numbers, I had doubt
this really was the case.

-- 
Jean Delvare

  reply	other threads:[~2009-11-20 11:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4AF91F70.10106@ladisch.de>
2009-11-20  8:15 ` [PATCH] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-20 10:22   ` Serge Belyshev
2009-11-20 10:44     ` [lm-sensors] " Jean Delvare
2009-11-20 10:47     ` [PATCH v2] " Clemens Ladisch
2009-11-20 11:30       ` Jean Delvare [this message]
2009-11-20 11:56         ` Clemens Ladisch
2009-11-20 12:18           ` Jean Delvare
2009-11-23  7:45             ` [PATCH v3] " Clemens Ladisch
2009-11-23 13:51               ` Jean Delvare
2009-11-23 15:29                 ` Clemens Ladisch
2009-11-23 19:05                   ` Jean Delvare
2009-11-24  8:43                     ` Clemens Ladisch
2009-11-24 13:26                       ` Jean Delvare
2009-11-24 14:09                         ` Clemens Ladisch
2009-11-24 20:11                           ` Jean Delvare
2009-11-25  9:51                             ` Clemens Ladisch
2009-11-26 20:44                               ` Jean Delvare
2009-11-27 13:03                                 ` Clemens Ladisch
2010-01-10 14:45                                   ` Jean Delvare
2010-01-15  9:57                                     ` Clemens Ladisch
2010-01-15 13:31                                       ` Jean Delvare
2009-11-24  8:43                     ` [PATCH v4] " Clemens Ladisch
2009-11-25 19:45                       ` Andrew Morton
2009-11-26  7:46                         ` Clemens Ladisch
2009-11-27 15:43                       ` Jean Delvare
2009-11-28  7:48                         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091120123016.19d98ab4@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=akpm@linux-foundation.org \
    --cc=belyshev@depni.sinp.msu.ru \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox