Re: [RFC PATCH 1/5] tty: push the BKL down into the handlers a bit

[Dan Carpenter <error27@gmail.com>]

On Wed, Nov 18, 2009 at 02:25:43PM +0000, Alan Cox wrote:
> Start trying to untangle the remaining BKL mess
> 
> Signed-off-by: Alan "I must be out of my tree" Cox <alan@linux.intel.com>
> ---
> 
>  drivers/char/pty.c       |    2 -
>  drivers/char/tty_io.c    |  140 ++++++++++++++++++++++++++--------------------
>  drivers/char/tty_ldisc.c |   13 ++++
>  include/linux/tty.h      |    2 -
>  4 files changed, 94 insertions(+), 63 deletions(-)
> 

  1565                  if (o_tty->termios != tty->driver->other->termios[idx]) {
  1566                          unlock_kernel();
  1567                          printk(KERN_DEBUG "tty_release_dev: other->termios[%d] "
  1568                                            "not o_termios for (%s)\n",
  1569                                 idx, tty->name);
  1570                          return 0;
  1571                  }
  1572                  if (o_tty->link != tty) {

We would need an unlock_kernel() here.

  1573                          printk(KERN_DEBUG "tty_release_dev: bad pty pointers\n");
  1574                          return 0;
  1575                  }

regards,
dan carpenter