Re: [PATCH] Add support for Mobilcom Debitel USB UMTS Surf-Stick to option driver

Gernot Hillier
2009-11-27T18:11:18Z

Hi!

Matthias Urlichs schrieb:
> On Fri, 2009-11-27 at 13:49 +0100, Gernot Hillier wrote:
>> + /* 4G Systems W14 simply ignores this message on interface 0 & 1
>> + and would cause long timeouts when calling usb_control_msg() */
>> + if (serial->dev->descriptor.idVendor == FOUR_G_SYSTEMS_VENDOR_ID &&
>> + serial->dev->descriptor.idProduct == FOUR_G_SYSTEMS_PRODUCT_W14 &&
>> + (ifNum == 0 || ifNum == 1) )
>> + return -EIO;
>>
> I'd appreciate if you'd implement this generically.
>
> I.e., use the driver_info field of struct usb_device for an appropriate
> blacklist flag. (It's not going to be the only one.)

Sure. I'll have a look into that ASAP.

Could you do me a favor and apply the first two hunks (i.e. add the
vendor/device id) in the meantime?

This makes the driver functional in general. And - ehrm, would save me
some time, because these hunks have to be rebased frequently. ;-)

The 3rd hunk (we're talking about) is just an "optimization" to make
impatient userspace applications happy...

--
Gernot