Re: [PATCH tip/core/rcu 0/3] rcu: resend of grace-period stall and cleanup patches

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> Hello!
> 
> This patch series is a resend of the three RCU patches that are candidates
> for the upcoming 2.6.33 merge window, but that are not yet in -tip.
> These are:
> 
> 1.	A fix for a grace-period-stall bug that occurs on large
> 	machines.
[...]

Hi Paul,

I was thinking about the last bugs you discovered. Some caracteristics
they had in common were that they occur only on large marchines (32+ or
64+ CPUs). This is caused by the fact that some of your code is only
covered by tests when the number of CPUs go over the architecture size
(in bits).

I managed to cover this kind of scenario with smaller state-space in the
LTTng formal models (but it also applies to kernel code) by tweaking the
code, with bitmasks, to ensure that the number of bits the code uses is,
e.g., no more than the minimum amount of required bits. Therefore, you
are ensured to run into overflow scenarios either more quickly or, as in
this case, on decently-sized hardware.

Hope this helps,

Thanks,

Mathieu

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68