From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756826AbZKWUIU (ORCPT ); Mon, 23 Nov 2009 15:08:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756189AbZKWUIS (ORCPT ); Mon, 23 Nov 2009 15:08:18 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:42490 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756418AbZKWUIR (ORCPT ); Mon, 23 Nov 2009 15:08:17 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:message-id:content-type:content-transfer-encoding; b=Iohfz9wT8R7/AaDbVvdDxRXNVaCNe0YJjv5iecTheyG5nXxZooWZwwF6FLlHjf+/4F XE2ofAdiwmR9THAo4g5hjja4kIdMs4IMKECCHqSEtBF0Lg24PM8HaHE1OnPeJBJQeM3h FcXIVVATYE/pgEpDMfgWmh5Qi9sF8nvCYOFOI= From: Bartlomiej Zolnierkiewicz To: Sergei Shtylyov Subject: Re: [PATCH 1/2] pata_hpt37x: add proper cable detection methods Date: Mon, 23 Nov 2009 21:07:22 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.31.5-0.1-desktop; KDE/4.3.1; x86_64; ; ) Cc: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <200911191910.44609.bzolnier@gmail.com> <4B0AE59F.7040202@ru.mvista.com> In-Reply-To: <4B0AE59F.7040202@ru.mvista.com> MIME-Version: 1.0 Message-Id: <200911232107.22868.bzolnier@gmail.com> Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 23 November 2009 08:42:23 pm Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > --- > > drivers/ata/pata_hpt37x.c | 86 +++++++++++++++++++++++++++++----------------- > > 1 file changed, 56 insertions(+), 30 deletions(-) > > > Index: b/drivers/ata/pata_hpt37x.c > > =================================================================== > > --- a/drivers/ata/pata_hpt37x.c > > +++ b/drivers/ata/pata_hpt37x.c > > @@ -303,6 +303,59 @@ static unsigned long hpt370a_filter(stru > > As this driver still carries a version info, don't we need to update it? While doing the previously mentioned PATA rework I've looked at the ratio of patches actually updating version numbers and not doing so. This lead me to the same conclusions as with version numbers in IDE drivers previously.. However this is just my opinion so if you for some reason would like to bump version numbers of some drivers I won't complain.. -- Bartlomiej Zolnierkiewicz