public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: James Morris <jmorris@namei.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Andrew G. Morgan" <morgan@kernel.org>,
	Steve Grubb <sgrubb@redhat.com>,
	linux-security-module@vger.kernel.org,
	Kees Cook <kees.cook@canonical.com>,
	Andreas Gruenbacher <agruen@suse.de>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	George Wilson <gcwilson@us.ibm.com>,
	KaiGai Kohei <kaigai@kaigai.gr.jp>
Subject: Re: [PATCH] remove CONFIG_SECURITY_FILE_CAPABILITIES compile option
Date: Mon, 23 Nov 2009 17:12:56 -0600	[thread overview]
Message-ID: <20091123231256.GB11570@us.ibm.com> (raw)
In-Reply-To: <4B0B0DDB.4070504@oracle.com>

Quoting Randy Dunlap (randy.dunlap@oracle.com):
> Serge E. Hallyn wrote:
> > As far as I know, all distros currently ship kernels with default
> > CONFIG_SECURITY_FILE_CAPABILITIES=y.  Since having the option on
> > leaves a 'no_file_caps' option to boot without file capabilities,
> > the main reason to keep the option is that turning it off saves
> > you (on my s390x partition) 5k.  In particular, vmlinux sizes
> > came to:
> > 
> > without patch fscaps=n:		 	53598392
> > without patch fscaps=y:		 	53603406
> > with this patch applied:		53603342
> > 
> > with the security-next tree.
> > 
> > Against this we must weigh the fact that there is no simple way for
> > userspace to figure out whether file capabilities are supported,
> > while things like per-process securebits, capability bounding
> > sets, and adding bits to pI if CAP_SETPCAP is in pE are not supported
> > with SECURITY_FILE_CAPABILITIES=n, leaving a bit of a problem for
> > applications wanting to know whether they can use them and/or why
> > something failed.
> > 
> > It also adds another subtly different set of semantics which we must
> > maintain at the risk of severe security regressions.
> 
> Hi,
> 
> This is or is not the same security option that is referred to in
> (new:) http://bugzilla.kernel.org/show_bug.cgi?id=14675 ?

I don't know.  I would assume he meant 'CONFIG_SECURITY', but that
wouldn't make sense since it should make no difference if no specific
LSM is turned on.

I will subscribe to the bug so I can see his response.  If it is in
fact CONFIG_SECURITY_FILE_CAPABILITIES, then a binary which is setuid-root
may be installed with some file capabilities, but without enough caps
to do what it needs.

thanks,
-serge

  reply	other threads:[~2009-11-23 23:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 22:21 [PATCH] remove CONFIG_SECURITY_FILE_CAPABILITIES compile option Serge E. Hallyn
2009-11-23 22:34 ` Randy Dunlap
2009-11-23 23:12   ` Serge E. Hallyn [this message]
2009-11-23 23:13 ` Serge E. Hallyn
2009-11-24  4:59 ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123231256.GB11570@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=agruen@suse.de \
    --cc=gcwilson@us.ibm.com \
    --cc=jmorris@namei.org \
    --cc=kaigai@kaigai.gr.jp \
    --cc=kees.cook@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=morgan@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=randy.dunlap@oracle.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox