From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932569AbZKXJyw (ORCPT ); Tue, 24 Nov 2009 04:54:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932524AbZKXJyv (ORCPT ); Tue, 24 Nov 2009 04:54:51 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:61551 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932504AbZKXJyu (ORCPT ); Tue, 24 Nov 2009 04:54:50 -0500 From: Arnd Bergmann To: monstr@monstr.eu Subject: Re: [PATCH] serial: 8250: Add ns16550a to OF compatible list Date: Tue, 24 Nov 2009 09:53:52 +0000 User-Agent: KMail/1.12.2 (Linux/2.6.31bisect; KDE/4.3.2; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, grant.likely@secretlab.ca, john.williams@petalogix.com, stable@kernel.org, chrisw@sous-sol.org, greg@kroah.com, alonz@discretix.com References: <1259054502-28284-1-git-send-email-monstr@monstr.eu> <1259054502-28284-2-git-send-email-monstr@monstr.eu> In-Reply-To: <1259054502-28284-2-git-send-email-monstr@monstr.eu> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911240953.52204.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/BdwGxwKHGqgPTM1cJUe01ZE/+vqxwItYJatU ab2r9cDmsPnjC5TtiuKYbXMwd35ptn2/wGb5B5jR9QA7sCaKgK sYJ1oXfw3x44nXG4vHaZg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 24 November 2009 09:21:42 monstr@monstr.eu wrote: > From: Michal Simek > > Signed-off-by: Michal Simek I was holding off on that patch to make sure the discussion had ended, but this part certainly looks good. Some points on form though: * The patch is missing a changelog, which is always required, but especially important if you're changing code that you want in -stable! * You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS file, but scripts/get_maintainer.pl would have given you a good indication of who feels responsible. You also didn't cc Alon, who submitted a similar patch [1] just days ago, which I assume prompted you to send this. If you didn't see his patch, nevermind. * Patches go into mainline first, then into stable [2]. Asking for inclusion into -stable for a patch that is still being discussed for inclusion in -next is the wrong order, no matter how obvious and trivial the patch is. Anyway, thanks for the patch. I'll follow up with a new version with a better changelog for the tty tree. Any suggestions about what to do on 2.6.32? Should it go in there now, or would this go into a -stable release since it's not a regression? Acked-by: Arnd Bergmann [1] http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg39015.html [2] http://lkml.indiana.edu/hypermail/linux/kernel/0504.3/1369.html > --- > drivers/serial/of_serial.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c > index 02406ba..b047c38 100644 > --- a/drivers/serial/of_serial.c > +++ b/drivers/serial/of_serial.c > @@ -161,6 +161,7 @@ static int of_platform_serial_remove(struct of_device *ofdev) > static struct of_device_id __devinitdata of_platform_serial_table[] = { > { .type = "serial", .compatible = "ns8250", .data = (void *)PORT_8250, }, > { .type = "serial", .compatible = "ns16450", .data = (void *)PORT_16450, }, > + { .type = "serial", .compatible = "ns16550a", .data = (void *)PORT_16550A, }, > { .type = "serial", .compatible = "ns16550", .data = (void *)PORT_16550, }, > { .type = "serial", .compatible = "ns16750", .data = (void *)PORT_16750, }, > { .type = "serial", .compatible = "ns16850", .data = (void *)PORT_16850, }, >