From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Luming Yu <luming.yu@gmail.com>
Subject: Re: [PATCH 1/2] hrtimer: correct a few numbers in comments and printk outputs
Date: Tue, 24 Nov 2009 11:14:03 +0100 [thread overview]
Message-ID: <20091124101403.GA25364@pengutronix.de> (raw)
In-Reply-To: <20091123152516.729e1407.akpm@linux-foundation.org>
Hello Andrew,
On Mon, Nov 23, 2009 at 03:25:16PM -0800, Andrew Morton wrote:
> On Fri, 20 Nov 2009 20:23:39 +0100
> Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
>
> > @@ -52,7 +52,7 @@ int tick_dev_program_event(struct clock_event_device *dev, ktime_t expires,
> > printk(KERN_WARNING
> > "CE: %s increasing min_delta_ns to %lu nsec\n",
> > dev->name ? dev->name : "?",
> > - dev->min_delta_ns << 1);
> > + dev->min_delta_ns);
> >
> > i = 0;
> > }
>
> This one's already in linux-next:
>
> @@ -50,9 +50,9 @@ int tick_dev_program_event(struct clock_
> dev->min_delta_ns += dev->min_delta_ns >> 1;
>
> printk(KERN_WARNING
> - "CE: %s increasing min_delta_ns to %lu nsec\n",
> + "CE: %s increasing min_delta_ns to %llu nsec\n",
> dev->name ? dev->name : "?",
> - dev->min_delta_ns << 1);
> + (unsigned long long) dev->min_delta_ns << 1);
'<< 1' is wrong here, too.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-11-24 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 19:23 [PATCH 1/2] hrtimer: correct a few numbers in comments and printk outputs Uwe Kleine-König
2009-11-20 19:23 ` [PATCH 2/2] clockevents: assert min_delta_ns being increased in error path Uwe Kleine-König
2009-11-23 23:25 ` [PATCH 1/2] hrtimer: correct a few numbers in comments and printk outputs Andrew Morton
2009-11-24 10:14 ` Uwe Kleine-König [this message]
2009-11-25 19:56 ` Andrew Morton
2009-11-25 20:18 ` Thomas Gleixner
2009-11-25 21:18 ` Andrew Morton
2009-11-25 22:07 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124101403.GA25364@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@gmail.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox