From: Dimitri Sivanich <sivanich@sgi.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
David Miller <davem@davemloft.net>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v6] x86/apic: limit irq affinity
Date: Tue, 24 Nov 2009 15:41:21 -0600 [thread overview]
Message-ID: <20091124214121.GA15182@sgi.com> (raw)
In-Reply-To: <m1ws1f6csh.fsf@fess.ebiederm.org>
On Tue, Nov 24, 2009 at 09:41:18AM -0800, Eric W. Biederman wrote:
> As for the UV code, what we are looking at is a fundamental irq
> routing property. Those irqs cannot be routed to some cpus. That is
> something the code that sets up the routes needs to be aware of.
Correct. We can't allow an interrupt to be routed to an invalid node.
> Dimitri could you put your the extra code in assign_irq_vector instead
> of in the callers of assign_irq_vector? Since the probably is not
> likely to stay unique we probably want to put the information you base
> things on in struct irq_desc, but the logic I seems to live best in
> in assign_irq_vector.
So you're saying continue to use the node value in irq_desc, or add a cpumask there (which will add some size to that structure)? I'll have to take another look at assign_irq_vector, but as things are currently structured, we don't return any sort of valid cpumask that we'd need for further processing in the caller functions. One would need to pass that back or store that cpumask someplace, like irq_desc?
next prev parent reply other threads:[~2009-11-24 21:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 21:11 [PATCH v6] x86/apic: limit irq affinity Dimitri Sivanich
2009-11-21 18:49 ` Eric W. Biederman
2009-11-22 1:14 ` Dimitri Sivanich
2009-11-24 13:20 ` Thomas Gleixner
2009-11-24 13:39 ` Peter Zijlstra
2009-11-24 13:55 ` Thomas Gleixner
2009-11-24 14:50 ` Arjan van de Ven
2009-11-24 17:41 ` Eric W. Biederman
2009-11-24 18:00 ` Peter P Waskiewicz Jr
2009-11-24 18:20 ` Ingo Molnar
2009-11-24 18:27 ` Yinghai Lu
2009-11-24 18:32 ` Peter Zijlstra
2009-11-24 18:59 ` Yinghai Lu
2009-11-24 21:41 ` Dimitri Sivanich [this message]
2009-11-24 21:51 ` Thomas Gleixner
2009-11-24 23:06 ` Eric W. Biederman
2009-11-25 1:23 ` Thomas Gleixner
2009-11-24 22:42 ` Eric W. Biederman
2009-11-25 15:40 ` Arjan van de Ven
2009-12-03 16:50 ` Dimitri Sivanich
2009-12-03 16:53 ` Waskiewicz Jr, Peter P
2009-12-03 17:01 ` Dimitri Sivanich
2009-12-03 17:07 ` Waskiewicz Jr, Peter P
2009-12-03 17:19 ` Dimitri Sivanich
2009-12-03 18:50 ` Waskiewicz Jr, Peter P
2009-12-04 16:42 ` Dimitri Sivanich
2009-12-04 21:17 ` Peter P Waskiewicz Jr
2009-12-04 23:12 ` Eric W. Biederman
2009-12-05 10:38 ` Peter P Waskiewicz Jr
2009-12-07 13:44 ` Dimitri Sivanich
2009-12-07 13:39 ` Dimitri Sivanich
2009-12-07 23:28 ` Peter P Waskiewicz Jr
2009-12-08 15:04 ` Dimitri Sivanich
2009-12-11 3:16 ` david
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124214121.GA15182@sgi.com \
--to=sivanich@sgi.com \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=peterz@infradead.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox