public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Liuweni" <qingshenlwy@gmail.com>
To: "linux-kernel" <linux-kernel@vger.kernel.org>
Cc: "xgr178" <xgr178@163.com>, "Jiri Kosina" <jkosina@suse.cz>,
	"qingshenlwy" <qingshenlwy@tom.com>
Subject: [PATCH]irq/core:Add a length limitation
Date: Tue, 24 Nov 2009 21:47:54 +0800	[thread overview]
Message-ID: <200911242147508598860@gmail.com> (raw)

In the register_handler_proc(), the max length of irqaction->name is MAX_NAMELEN.
And this function will call name_unique() to compare name with other irqs'.
There is no any code for limitation the length.
I add a warning in the function to notice that the irqaction->name is too long.

Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
---
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 0832145..9ab6e04 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -196,6 +196,9 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
 	char name [MAX_NAMELEN];
 	struct irq_desc *desc = irq_to_desc(irq);
 
+	if(strlen(action->name) >= MAX_NAMELEN)
+		WARN_ON(1);
+
 	if (!desc->dir || action->dir || !action->name ||
 					!name_unique(irq, action))
 		return;
---

Best Regards,
Liuweni
2009-11-24


             reply	other threads:[~2009-11-24 13:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 13:47 Liuweni [this message]
2009-11-24 14:45 ` [PATCH]irq/core:Add a length limitation Ingo Molnar
2009-11-25 13:20 ` Liuweni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911242147508598860@gmail.com \
    --to=qingshenlwy@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qingshenlwy@tom.com \
    --cc=xgr178@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox