* [patch] twl4030: fix ELF section mismatch...
@ 2009-11-23 18:54 Daniel J Blueman
2009-11-24 23:37 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Daniel J Blueman @ 2009-11-23 18:54 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Linux Kernel
Since twl4030_probe is only called from functions in the init ELF
section, annotate it so.
Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
---
diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
index a1c47ee..2fe514d 100644
--- a/drivers/mfd/twl4030-core.c
+++ b/drivers/mfd/twl4030-core.c
@@ -763,7 +763,7 @@ static int twl4030_remove(struct i2c_client *client)
}
/* NOTE: this driver only handles a single twl4030/tps659x0 chip */
-static int
+static int __init
twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
{
int status;
--
Daniel J Blueman
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] twl4030: fix ELF section mismatch...
2009-11-23 18:54 [patch] twl4030: fix ELF section mismatch Daniel J Blueman
@ 2009-11-24 23:37 ` Samuel Ortiz
2009-11-25 10:10 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Ortiz @ 2009-11-24 23:37 UTC (permalink / raw)
To: Daniel J Blueman, Mark Brown; +Cc: Linux Kernel
On Mon, Nov 23, 2009 at 06:54:06PM +0000, Daniel J Blueman wrote:
> Since twl4030_probe is only called from functions in the init ELF
> section, annotate it so.
>
> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Mark, thanks for carrying this one with your twl4030 branch.
Cheers,
Samuel.
> ---
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index a1c47ee..2fe514d 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -763,7 +763,7 @@ static int twl4030_remove(struct i2c_client *client)
> }
>
> /* NOTE: this driver only handles a single twl4030/tps659x0 chip */
> -static int
> +static int __init
> twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> int status;
> --
> Daniel J Blueman
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] twl4030: fix ELF section mismatch...
2009-11-24 23:37 ` Samuel Ortiz
@ 2009-11-25 10:10 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2009-11-25 10:10 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Daniel J Blueman, Linux Kernel
On Wed, Nov 25, 2009 at 12:37:55AM +0100, Samuel Ortiz wrote:
> On Mon, Nov 23, 2009 at 06:54:06PM +0000, Daniel J Blueman wrote:
> > Since twl4030_probe is only called from functions in the init ELF
> > section, annotate it so.
> >
> > Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> Mark, thanks for carrying this one with your twl4030 branch.
Sure. Daniel, could you please resend the patch to me - I've deleted
the original.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-25 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-23 18:54 [patch] twl4030: fix ELF section mismatch Daniel J Blueman
2009-11-24 23:37 ` Samuel Ortiz
2009-11-25 10:10 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox