From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>
Cc: lrg@slimlogic.co.uk, dbrownell@users.sourceforge.net,
linux-kernel@vger.kernel.org, peter.de-schrijver@nokia.com,
eduardo.valentin@nokia.com
Subject: Re: [PATCHv2 3/3] Define critical regulators as always_on
Date: Wed, 25 Nov 2009 10:14:07 +0000 [thread overview]
Message-ID: <20091125101407.GA17420@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1259143495-9480-4-git-send-email-ext-juha.1.keski-saari@nokia.com>
On Wed, Nov 25, 2009 at 12:04:55PM +0200, Juha Keski-Saari wrote:
> + if (pdev->id == TWL4030_REG_VIO ||
> + pdev->id == TWL4030_REG_VDD1 ||
> + pdev->id == TWL4030_REG_VDD2 ||
> + pdev->id == TWL4030_REG_VPLL1 ||
> + pdev->id == TWL4030_REG_VINTANA1 ||
> + pdev->id == TWL4030_REG_VINTANA2 ||
> + pdev->id == TWL4030_REG_VINTDIG)
> + c->always_on = true;
This would be a bit clearer and much more idiomatic as a switch
statement.
next prev parent reply other threads:[~2009-11-25 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 10:04 [PATCHv2 0/3] for-next: Add all twl4030 regulators to RegFW Juha Keski-Saari
2009-11-25 10:04 ` [PATCHv2 1/3] twl4030-regulator: Add all TWL regulators to twreg_info Juha Keski-Saari
2009-11-25 13:38 ` Juha Keski-Saari
2009-11-25 13:49 ` Liam Girdwood
2009-11-25 14:22 ` Juha Keski-Saari
2009-11-25 14:33 ` Mark Brown
2009-11-25 18:19 ` Liam Girdwood
2009-11-25 10:04 ` [PATCHv2 2/3] Reset REMAP configuration in regulator probe Juha Keski-Saari
2009-11-25 10:04 ` [PATCHv2 3/3] Define critical regulators as always_on Juha Keski-Saari
2009-11-25 10:14 ` Mark Brown [this message]
2009-11-25 10:29 ` Juha Keski-Saari
2009-11-25 11:13 ` Mark Brown
2009-11-25 11:36 ` Juha Keski-Saari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125101407.GA17420@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dbrownell@users.sourceforge.net \
--cc=eduardo.valentin@nokia.com \
--cc=ext-juha.1.keski-saari@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox