From: Andrew Morton <akpm@linux-foundation.org>
To: Philip Langdale <philipl@overt.org>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
Pierre Ossman <pierre@ossman.eu>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Port ricoh_mmc from driver to pci quirk.
Date: Wed, 25 Nov 2009 11:35:01 -0800 [thread overview]
Message-ID: <20091125113501.1f4d42b9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20091125085324.1ef9ae1f@fido2.homeip.net>
On Wed, 25 Nov 2009 08:53:24 -0800
Philip Langdale <philipl@overt.org> wrote:
> On Wed, 25 Nov 2009 16:58:41 +0200
> Maxim Levitsky <maximlevitsky@gmail.com> wrote:
>
> > >From 5c5e6f5ab1a5a09a430f410cab4b160a5e65501c Mon Sep 17 00:00:00
> > >2001
> > From: Maxim Levitsky <maximlevitsky@gmail.com>
> > Date: Wed, 25 Nov 2009 16:37:46 +0200
> > Subject: [PATCH] Port ricoh_mmc from driver to pci quirk.
> > This is much cleaner and correct solution
This patch actually fixes a bug but the changelog forgot to tell us
this important fact.
> I'm fine with the concept, but when I originally started work on
> Ricoh support, Pierre specifically didn't want a pci quirk.
>
> Pierre wrote:
> > I'd rather we didn't. The current style of quirks are bad enough,
> > making them even more vendor or device specific is a bit more than I'm
> > willing to accept right now (seriously, how hard can it be to follow
> > the damn spec?).
Can the bug be fixed by other means, within ricoh_mmc.c?
It's a bit sad to add a lump of code to everyone's kernel like this -
what percentage of those machines actually have a ricoh mmc controller?
next prev parent reply other threads:[~2009-11-25 19:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 0:13 The work of ricoh_mmc isn't detected by pci core Maxim Levitsky
2009-11-24 0:21 ` Philip Langdale
2009-11-25 14:55 ` Maxim Levitsky
2009-11-25 14:58 ` [PATCH] Port ricoh_mmc from driver to pci quirk Maxim Levitsky
2009-11-25 16:53 ` Philip Langdale
2009-11-25 19:35 ` Andrew Morton [this message]
2009-11-25 23:40 ` Maxim Levitsky
2009-11-26 1:30 ` Philip Langdale
2009-11-26 23:51 ` Maxim Levitsky
2009-11-26 23:53 ` [PATCH v2] port ricoh_mmc to be " Maxim Levitsky
2009-11-27 7:55 ` Philip Langdale
2010-01-08 15:24 ` Maxim Levitsky
2010-01-08 15:40 ` Philip Langdale
2010-01-12 23:43 ` Andrew Morton
2010-01-13 1:23 ` Philip Langdale
2010-01-13 6:46 ` Wolfram Sang
2010-01-29 13:37 ` [PATCH v3] port ricoh_mmc to " Maxim Levitsky
2010-01-29 16:06 ` Philip Langdale
2010-01-29 22:10 ` Maxim Levitsky
2010-01-30 2:18 ` Philip Langdale
2010-01-29 16:33 ` Wolfram Sang
2010-01-29 22:13 ` Maxim Levitsky
2010-01-30 21:28 ` [PATCH] Port " Maxim Levitsky
2010-02-01 15:45 ` Maxim Levitsky
2009-11-25 20:30 ` [PATCH] Port ricoh_mmc from driver " Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125113501.1f4d42b9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=philipl@overt.org \
--cc=pierre@ossman.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox