Re: [PATCH 6/9] tracing: Convert some block events to DEFINE_EVENT

[Jens Axboe <jens.axboe@oracle.com>]

On Thu, Nov 26 2009, Ingo Molnar wrote:
> 
> * Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > On Thu, Nov 26 2009, Li Zefan wrote:
> > > use TRACE_EVENT_TEMPLATE to remove duplicate code:
> > > 
> > >    text    data     bss     dec     hex filename
> > >   53570    3284     184   57038    dece block/blk-core.o.old
> > >   43702    3284     144   47130    b81a block/blk-core.o
> > 
> > Nice! When I played with the writeback tracing, I did notice that code
> > bloat does get pretty severe quickly.
> > 
> > I have applied this to for-2.6.33, thanks a lot.
> 
> Note that it wont build in your tree, because the TRACE_EVENT_TEMPLATE / 
> DEFINE_EVENT facility this relies on is not upstream yet.
> 
> The events are not affected in any way (and block/* is not modified) - 
> it's just a more efficient representation of the same. I've applied them 
> to -tip, to keep the facility and dependent updates in a single place.

OK, lets merge them through -tip then. You can add my acked-by.

-- 
Jens Axboe