From: Oleg Nesterov <oleg@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
hidehiro.kawai.ez@hitachi.com, lethal@linux-sh.org,
mingo@elte.hu, roland@redhat.com, vapier@gentoo.org,
Takahiro Yasui <tyasui@redhat.com>
Subject: Re: + binfmt-introduce-coredump-parameter-structure.patch added to -mm tree
Date: Thu, 26 Nov 2009 17:51:08 +0100 [thread overview]
Message-ID: <20091126165108.GA13231@redhat.com> (raw)
In-Reply-To: <4B0EA3AA.5070003@redhat.com>
On 11/26, Masami Hiramatsu wrote:
>
> $ grep -r DUMP_WRITE arch/*/include
> arch/ia64/include/asm/elf.h: DUMP_WRITE(&phdr, sizeof(phdr)); \
> arch/ia64/include/asm/elf.h: DUMP_WRITE((void *) gate_phdrs[\
arch/um/sys-i386/asm/elf.h uses DUMP_WRITE() too.
> Oops, certainly, that's a problem.
> IMHO, we should not do like that, all parameter required by a macro should be
> specified explicitly, since it reduces readability so much...
> I think we'd better make those macros inline function, check it's return value
> for error handling.
Agreed, DUMP_WRITE() in its current form should die. Not only
it has implicit parameter, it does "goto" from the macro body
and it has multiple definitions withing the same file.
But perhaps this needs a separate patch? It is not trivial to kill
DUMP_WRITE(), you can fix this patch if you change DUMP_WRITE()
to use cprm->file instead of file.
Oleg.
next prev parent reply other threads:[~2009-11-26 16:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200911202212.nAKMCF2v012068@imap1.linux-foundation.org>
2009-11-26 8:53 ` + binfmt-introduce-coredump-parameter-structure.patch added to -mm tree KOSAKI Motohiro
2009-11-26 15:50 ` Masami Hiramatsu
2009-11-26 16:51 ` Oleg Nesterov [this message]
2009-11-29 3:59 ` Masami Hiramatsu
2009-11-29 4:39 ` [PATCH v2] mm: Introduce coredump parameter structure Masami Hiramatsu
2009-11-29 4:41 ` Masami Hiramatsu
2009-11-29 15:10 ` [PATCH][RFC] tracepoint: signal coredump (Re: [PATCH v2] mm: Introduce coredump parameter structure) Masami Hiramatsu
2009-12-02 20:46 ` [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint Masami Hiramatsu
2009-12-03 10:39 ` Ingo Molnar
2009-12-03 11:32 ` Masami Hiramatsu
2009-12-05 7:16 ` Ingo Molnar
2009-12-07 17:19 ` Masami Hiramatsu
2009-12-05 7:18 ` KOSAKI Motohiro
2009-12-07 15:25 ` Masami Hiramatsu
2009-12-08 1:51 ` KOSAKI Motohiro
2009-12-08 20:40 ` [PATCH v3] " Masami Hiramatsu
2009-12-09 5:34 ` KOSAKI Motohiro
2009-12-09 16:07 ` Masami Hiramatsu
2009-12-09 16:16 ` Masami Hiramatsu
2009-12-09 20:38 ` [PATCH v4] " Masami Hiramatsu
2009-12-10 0:09 ` KOSAKI Motohiro
2009-12-02 0:18 ` [PATCH v2] mm: Introduce coredump parameter structure Andrew Morton
2009-12-02 0:27 ` KOSAKI Motohiro
2009-12-02 0:29 ` Masami Hiramatsu
2009-12-02 9:50 ` Ingo Molnar
2009-12-02 18:07 ` Masami Hiramatsu
2009-12-02 0:41 ` [PATCH v2] [RESEND] " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126165108.GA13231@redhat.com \
--to=oleg@redhat.com \
--cc=dhowells@redhat.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tyasui@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox