Re: [PATCH] pata_it8213: MWDMA0 is unsupported

Bartlomiej Zolnierkiewicz
2009-11-26T17:02:00Z

On Thursday 26 November 2009 05:28:36 pm Bartlomiej Zolnierkiewicz wrote:
>
> MWDMA0 timings cannot be met with the PIIX based controller
> programming interface.
>
> This change should be safe as this is how we have been doing
> things in IDE it8213 host driver for years.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> Verified with the documentation (similar case as with pata_efar).

Uhhh, no...

Too many damn drivers.

Too much damn duplication.

Too much damn subtle differences here and there.

The hardware is probably fine for MWMDA0 when it comes to pata_{efar,it8213},
it just not documented properly in the data sheet.

I'll drop those two patches from my tree and take some break..

> On top of patches from yesterday.
>
> drivers/ata/pata_it8213.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/ata/pata_it8213.c
> ===================================================================
> --- a/drivers/ata/pata_it8213.c
> +++ b/drivers/ata/pata_it8213.c
> @@ -227,7 +227,7 @@ static int it8213_init_one (struct pci_d
> static const struct ata_port_info info = {
> .flags = ATA_FLAG_SLAVE_POSS,
> .pio_mask = ATA_PIO4,
> - .mwdma_mask = ATA_MWDMA2,
> + .mwdma_mask = ATA_MWDMA12_ONLY,
> .udma_mask = ATA_UDMA6,
> .port_ops = &it8213_ops,
> };