From: Alessandro Zummo <a.zummo@towertech.it>
To: Johannes Weiner <jw@emlix.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Gortmaker <p_gortmaker@yahoo.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] rtc-x1205: fix rtc_time to y2k register value conversion
Date: Thu, 26 Nov 2009 22:40:54 +0100 [thread overview]
Message-ID: <20091126224054.7f2dfe21@linux.lan.towertech.it> (raw)
In-Reply-To: <20091126010234.GA31257@emlix.com>
On Thu, 26 Nov 2009 02:02:34 +0100
Johannes Weiner <jw@emlix.com> wrote:
> eah, I think so too, although I hope we can get feedback from the
> authors beforehand.
>
> Because #1 looks obvious to me and makes the driver at all usable for
> me but the code has been like that since the initial merge in 2006.
> So either
>
> a) nobody ever set the date with this thing,
> b) every embedded linux company has its own private patch or
> c) I am missing something,
>
> where likelyhood is in reverse order. That makes me feel slightly
> uncomfortable.
The last time I used an x1205 it worked nicely. It's been two or three
years since. However the datasheet says 0x19 o 0x20 so your patch
looks good.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
prev parent reply other threads:[~2009-11-26 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 16:32 [patch 1/3] rtc-x1205: fix rtc_time to y2k register value conversion Johannes Weiner
2009-11-25 16:32 ` [patch 2/3] rtc-x1205: reset clock to sane state after power failure Johannes Weiner
2009-11-25 16:32 ` [patch 3/3] rtc-x1205: unconditionally set date when setting clock Johannes Weiner
2009-11-25 22:11 ` [patch 1/3] rtc-x1205: fix rtc_time to y2k register value conversion Andrew Morton
2009-11-26 1:02 ` Johannes Weiner
2009-11-26 21:40 ` Alessandro Zummo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126224054.7f2dfe21@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=jw@emlix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox