From: Magnus Damm <magnus.damm@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, ian@mnementh.co.uk,
lethal@linux-sh.org, philipp.zabel@gmail.com,
akpm@linux-foundation.org, pierre@ossman.eu
Subject: [PATCH 03/03] mmc: Balance tmio-mmc cell enable()/disable() calls
Date: Fri, 27 Nov 2009 14:00:22 +0900 [thread overview]
Message-ID: <20091127050022.15251.43017.sendpatchset@rxone.opensource.se> (raw)
In-Reply-To: <20091127045956.15251.84958.sendpatchset@rxone.opensource.se>
From: Magnus Damm <damm@opensource.se>
This patch adds cell->disable() calls to the tmio-mmc
probe() error handling and the remove() function.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
drivers/mmc/host/tmio_mmc.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- 0016/drivers/mmc/host/tmio_mmc.c
+++ work/drivers/mmc/host/tmio_mmc.c 2009-11-26 19:10:14.000000000 +0900
@@ -577,14 +577,14 @@ static int __devinit tmio_mmc_probe(stru
if (ret >= 0)
host->irq = ret;
else
- goto unmap_ctl;
+ goto cell_disable;
disable_mmc_irqs(host, TMIO_MASK_ALL);
ret = request_irq(host->irq, tmio_mmc_irq, IRQF_DISABLED |
IRQF_TRIGGER_FALLING, dev_name(&dev->dev), host);
if (ret)
- goto unmap_ctl;
+ goto cell_disable;
mmc_add_host(mmc);
@@ -596,6 +596,9 @@ static int __devinit tmio_mmc_probe(stru
return 0;
+cell_disable:
+ if (cell->disable)
+ cell->disable(dev);
unmap_ctl:
iounmap(host->ctl);
host_free:
@@ -606,6 +609,7 @@ out:
static int __devexit tmio_mmc_remove(struct platform_device *dev)
{
+ struct mfd_cell *cell = (struct mfd_cell *)dev->dev.platform_data;
struct mmc_host *mmc = platform_get_drvdata(dev);
platform_set_drvdata(dev, NULL);
@@ -614,6 +618,8 @@ static int __devexit tmio_mmc_remove(str
struct tmio_mmc_host *host = mmc_priv(mmc);
mmc_remove_host(mmc);
free_irq(host->irq, host);
+ if (cell->disable)
+ cell->disable(dev);
iounmap(host->ctl);
mmc_free_host(mmc);
}
next prev parent reply other threads:[~2009-11-27 5:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 4:59 [PATCH 00/03] mmc: A few trivial changes for tmio-mmc Magnus Damm
2009-11-27 5:00 ` [PATCH 01/03] mmc: Let tmio-mmc use dev_name() with request_irq() Magnus Damm
2009-11-27 5:00 ` [PATCH 02/03] mmc: Remove const from tmio-mmc platform data V2 Magnus Damm
2009-11-27 5:00 ` Magnus Damm [this message]
2010-01-16 0:06 ` [PATCH 03/03] mmc: Balance tmio-mmc cell enable()/disable() calls Andrew Morton
2010-01-19 14:25 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127050022.15251.43017.sendpatchset@rxone.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ian@mnementh.co.uk \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=pierre@ossman.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox