public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Chris Mason <chris.mason@oracle.com>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 1/6] writeback: remove unused nonblocking and congestion checks
Date: Fri, 27 Nov 2009 18:59:09 +0800	[thread overview]
Message-ID: <20091127110407.243915604@intel.com> (raw)
In-Reply-To: 20091127105908.944744141@intel.com

[-- Attachment #1: writeback-remove-congested-checks-linux_fs_fs-writeback.patch --]
[-- Type: text/plain, Size: 1240 bytes --]

- no one is calling wb_writeback and write_cache_pages with
  wbc.nonblocking=1 any more
- lumpy pageout will want to do nonblocking writeback without the
  congestion wait

So remove the congestion checks as suggested by Chris.

CC: Chris Mason <chris.mason@oracle.com>
CC: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 fs/fs-writeback.c |    9 ---------
 1 file changed, 9 deletions(-)

--- linux.orig/fs/fs-writeback.c	2009-11-27 16:35:00.000000000 +0800
+++ linux/fs/fs-writeback.c	2009-11-27 18:54:50.000000000 +0800
@@ -657,14 +657,6 @@ static void writeback_inodes_wb(struct b
 			continue;
 		}
 
-		if (wbc->nonblocking && bdi_write_congested(wb->bdi)) {
-			wbc->encountered_congestion = 1;
-			if (!is_blkdev_sb)
-				break;		/* Skip a congested fs */
-			requeue_io(inode);
-			continue;		/* Skip a congested blockdev */
-		}
-
 		/*
 		 * Was this inode dirtied after sync_sb_inodes was called?
 		 * This keeps sync from extra jobs and livelock.
@@ -787,7 +779,6 @@ static long wb_writeback(struct bdi_writ
 			break;
 
 		wbc.more_io = 0;
-		wbc.encountered_congestion = 0;
 		wbc.nr_to_write = MAX_WRITEBACK_PAGES;
 		wbc.pages_skipped = 0;
 		writeback_inodes_wb(wb, &wbc);



  reply	other threads:[~2009-11-27 11:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27 10:59 [PATCH 0/6] trivial writeback cleanups/fixes V2 Wu Fengguang
2009-11-27 10:59 ` Wu Fengguang [this message]
2009-11-27 10:59 ` [PATCH 2/6] writeback: remove unused nonblocking and congestion checks (write_cache_pages) Wu Fengguang
2009-11-27 10:59 ` [PATCH 3/6] writeback: remove unused nonblocking and congestion checks (pohmelfs) Wu Fengguang
2009-11-27 10:59 ` [PATCH 4/6] writeback: remove unused nonblocking and congestion checks (xfs) Wu Fengguang
2009-11-27 11:40   ` Christoph Hellwig
2009-11-27 11:50     ` Wu Fengguang
2009-11-27 12:08       ` Christoph Hellwig
2009-11-27 10:59 ` [PATCH 5/6] writeback: remove the always false bdi_cap_writeback_dirty() test Wu Fengguang
2009-11-27 10:59 ` [PATCH 6/6] writeback: introduce wbc.for_background Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091127110407.243915604@intel.com \
    --to=fengguang.wu@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox