public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Evgeniy Polyakov <zbr@ioremap.net>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 3/6] writeback: remove unused nonblocking and congestion checks (pohmelfs)
Date: Fri, 27 Nov 2009 18:59:11 +0800	[thread overview]
Message-ID: <20091127110407.530393220@intel.com> (raw)
In-Reply-To: 20091127105908.944744141@intel.com

[-- Attachment #1: writeback-remove-congested-checks-linux_drivers_staging_pohmelfs_inode.patch --]
[-- Type: text/plain, Size: 1372 bytes --]

No one is calling wb_writeback and write_cache_pages with
wbc.nonblocking=1 any more. And lumpy pageout will want to do
nonblocking writeback without the congestion wait.

CC: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 drivers/staging/pohmelfs/inode.c |   10 ----------
 1 file changed, 10 deletions(-)

--- linux.orig/drivers/staging/pohmelfs/inode.c	2009-11-27 16:34:51.000000000 +0800
+++ linux/drivers/staging/pohmelfs/inode.c	2009-11-27 18:55:03.000000000 +0800
@@ -143,7 +143,6 @@ static int pohmelfs_writepages(struct ad
 	struct inode *inode = mapping->host;
 	struct pohmelfs_inode *pi = POHMELFS_I(inode);
 	struct pohmelfs_sb *psb = POHMELFS_SB(inode->i_sb);
-	struct backing_dev_info *bdi = mapping->backing_dev_info;
 	int err = 0;
 	int done = 0;
 	int nr_pages;
@@ -152,11 +151,6 @@ static int pohmelfs_writepages(struct ad
 	int scanned = 0;
 	int range_whole = 0;
 
-	if (wbc->nonblocking && bdi_write_congested(bdi)) {
-		wbc->encountered_congestion = 1;
-		return 0;
-	}
-
 	if (wbc->range_cyclic) {
 		index = mapping->writeback_index; /* Start from prev offset */
 		end = -1;
@@ -248,10 +242,6 @@ retry:
 
 			if (wbc->nr_to_write <= 0)
 				done = 1;
-			if (wbc->nonblocking && bdi_write_congested(bdi)) {
-				wbc->encountered_congestion = 1;
-				done = 1;
-			}
 
 			continue;
 out_continue:



  parent reply	other threads:[~2009-11-27 11:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27 10:59 [PATCH 0/6] trivial writeback cleanups/fixes V2 Wu Fengguang
2009-11-27 10:59 ` [PATCH 1/6] writeback: remove unused nonblocking and congestion checks Wu Fengguang
2009-11-27 10:59 ` [PATCH 2/6] writeback: remove unused nonblocking and congestion checks (write_cache_pages) Wu Fengguang
2009-11-27 10:59 ` Wu Fengguang [this message]
2009-11-27 10:59 ` [PATCH 4/6] writeback: remove unused nonblocking and congestion checks (xfs) Wu Fengguang
2009-11-27 11:40   ` Christoph Hellwig
2009-11-27 11:50     ` Wu Fengguang
2009-11-27 12:08       ` Christoph Hellwig
2009-11-27 10:59 ` [PATCH 5/6] writeback: remove the always false bdi_cap_writeback_dirty() test Wu Fengguang
2009-11-27 10:59 ` [PATCH 6/6] writeback: introduce wbc.for_background Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091127110407.530393220@intel.com \
    --to=fengguang.wu@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox