public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mmotm 2009-11-24-16-47 uploaded (gpio_max7301)
Date: Sat, 28 Nov 2009 17:21:17 +0100	[thread overview]
Message-ID: <20091128162117.GA9663@pengutronix.de> (raw)
In-Reply-To: <4B0DDDFE.5060600@xenotime.net>

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]


> This driver has build failures when CONFIG_I2C=m and
> MAX7301=y, MAX7301_I2C=y, MAX7301_SPI=y:
> 
> drivers/built-in.o: In function `max7301_i2c_write':
> max7301.c:(.text+0x2d9e): undefined reference to `i2c_smbus_write_byte_data'
> drivers/built-in.o: In function `max7301_i2c_read':
> max7301.c:(.text+0x2dc6): undefined reference to `i2c_smbus_read_byte_data'
> drivers/built-in.o: In function `max7301_init':
> max7301.c:(.init.text+0x42e): undefined reference to `i2c_register_driver'
> max7301.c:(.init.text+0x496): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `max7301_exit':
> max7301.c:(.exit.text+0x14): undefined reference to `i2c_del_driver'
> 
> 
> This kconfig syntax:
> 
> config GPIO_MAX7301
>         tristate "Maxim MAX730x GPIO expander"
>         depends on I2C || SPI_MASTER
> 
> allows GPIO_MAX7301 to be y when SPI_MASTER=y and I2C=m.
> If you want to do that, you'll need to handle CONFIG_I2C=m somehow.

ACK, will fix it.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-11-28 16:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25  0:47 mmotm 2009-11-24-16-47 uploaded akpm
2009-11-25 15:12 ` BUG at scsi_lib.c:1108 [Was: mmotm 2009-11-24-16-47 uploaded] Jiri Slaby
2009-11-25 15:19   ` James Bottomley
2009-11-25 20:22     ` Jiri Slaby
2009-11-25 21:13       ` Neil Brown
2009-11-26 10:17         ` Boaz Harrosh
2009-11-27  4:17         ` Neil Brown
2009-11-27 10:20           ` Jiri Slaby
2009-11-26  1:46 ` mmotm 2009-11-24-16-47 uploaded (gpio_max7301) Randy Dunlap
2009-11-28 16:21   ` Wolfram Sang [this message]
2009-12-15 22:43   ` Andrew Morton
2009-12-15 22:46     ` Randy Dunlap
2009-12-15 23:10       ` Andrew Morton
2009-12-16 11:30         ` Wolfram Sang
2009-11-27 10:33 ` ugly sound output (intel-hda) [was: mmotm 2009-11-24-16-47 uploaded] Jiri Slaby
2009-11-27 10:45   ` Takashi Iwai
2009-11-27 11:07     ` Jiri Slaby
2009-11-27 11:18       ` Takashi Iwai
2009-11-27 12:22         ` Jiri Slaby
2009-11-27 12:26           ` Takashi Iwai
2009-11-27 15:03 ` WARNING: kernel/smp.c:292 smp_call_function_single [Was: " Jiri Slaby
2009-11-27 15:17   ` Peter Zijlstra
2009-11-27 16:37     ` Thomas Gleixner
2009-11-27 16:44       ` Thomas Gleixner
2009-11-28 12:12       ` Avi Kivity
2009-11-30  8:58         ` Tejun Heo
2009-11-30  9:41           ` Avi Kivity
2009-11-30 10:02           ` Thomas Gleixner
2009-11-30 10:45             ` Tejun Heo
2009-11-30 11:02               ` [PATCH tip/sched/urgent] sched: revert 498657a478c60be092208422fefa9c7b248729c2 Tejun Heo
2009-11-30 11:13                 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091128162117.GA9663@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox