* [PATCH] virtio: set pci bus master enable bit
@ 2009-11-29 15:52 Michael S. Tsirkin
2009-12-01 0:04 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-11-29 15:52 UTC (permalink / raw)
To: Rusty Russell, Michael S. Tsirkin, Mark McLoughlin, linux-kernel,
virtualization, Anthony Liguori, kvm, Yan Vugenfirer
As all virtio devices perform DMA, we
must enable bus mastering for them to be
spec compliant.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/virtio/virtio_pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 28d9cf7..717bae1 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct pci_dev *pci_dev,
goto out_req_regions;
pci_set_drvdata(pci_dev, vp_dev);
+ pci_set_master(pci_dev);
/* we use the subsystem vendor/device id as the virtio vendor/device
* id. this allows us to use the same PCI vendor/device id for all
--
1.6.5.2.143.g8cc62
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: set pci bus master enable bit
2009-11-29 15:52 [PATCH] virtio: set pci bus master enable bit Michael S. Tsirkin
@ 2009-12-01 0:04 ` Rusty Russell
2009-12-04 23:10 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2009-12-01 0:04 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Mark McLoughlin, linux-kernel, virtualization, Anthony Liguori,
kvm, Yan Vugenfirer, Jesse Barnes
On Mon, 30 Nov 2009 02:22:01 am Michael S. Tsirkin wrote:
> As all virtio devices perform DMA, we
> must enable bus mastering for them to be
> spec compliant.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
> index 28d9cf7..717bae1 100644
> --- a/drivers/virtio/virtio_pci.c
> +++ b/drivers/virtio/virtio_pci.c
> @@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct pci_dev *pci_dev,
> goto out_req_regions;
>
> pci_set_drvdata(pci_dev, vp_dev);
> + pci_set_master(pci_dev);
I can believe this, but I have no idea if it's right. I've applied it, and
hope Jesse will comment if there's something wrong with it.
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: set pci bus master enable bit
2009-12-01 0:04 ` Rusty Russell
@ 2009-12-04 23:10 ` Jesse Barnes
0 siblings, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2009-12-04 23:10 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael S. Tsirkin, Mark McLoughlin, linux-kernel, virtualization,
Anthony Liguori, kvm, Yan Vugenfirer
On Tue, 1 Dec 2009 10:34:01 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Mon, 30 Nov 2009 02:22:01 am Michael S. Tsirkin wrote:
> > As all virtio devices perform DMA, we
> > must enable bus mastering for them to be
> > spec compliant.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/virtio/virtio_pci.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/virtio/virtio_pci.c
> > b/drivers/virtio/virtio_pci.c index 28d9cf7..717bae1 100644
> > --- a/drivers/virtio/virtio_pci.c
> > +++ b/drivers/virtio/virtio_pci.c
> > @@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct
> > pci_dev *pci_dev, goto out_req_regions;
> >
> > pci_set_drvdata(pci_dev, vp_dev);
> > + pci_set_master(pci_dev);
>
> I can believe this, but I have no idea if it's right. I've applied
> it, and hope Jesse will comment if there's something wrong with it.
Nope, nothing wrong with that afaict.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-04 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-29 15:52 [PATCH] virtio: set pci bus master enable bit Michael S. Tsirkin
2009-12-01 0:04 ` Rusty Russell
2009-12-04 23:10 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox