[PATCH] param: don't complain about unused module parameters.

[PATCH] param: don't complain about unused module parameters.

[Rusty Russell]

Jon confirms that recent modprobe will look in /proc/cmdline, so these
cmdline options can still be used.

See http://bugzilla.kernel.org/show_bug.cgi?id=14164

Reported-by: Adam Williamson <awilliam@redhat.com>
Cc: stable@kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 init/main.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/init/main.c b/init/main.c
--- a/init/main.c
+++ b/init/main.c
@@ -251,7 +251,7 @@ early_param("loglevel", loglevel);
 
 /*
  * Unknown boot options get handed to init, unless they look like
- * failed parameters
+ * unused parameters (modprobe will find them in /proc/cmdline).
  */
 static int __init unknown_bootoption(char *param, char *val)
 {
@@ -272,14 +272,9 @@ static int __init unknown_bootoption(cha
 	if (obsolete_checksetup(param))
 		return 0;
 
-	/*
-	 * Preemptive maintenance for "why didn't my misspelled command
-	 * line work?"
-	 */
-	if (strchr(param, '.') && (!val || strchr(param, '.') < val)) {
-		printk(KERN_ERR "Unknown boot option `%s': ignoring\n", param);
+	/* Unused module parameter. */
+	if (strchr(param, '.') && (!val || strchr(param, '.') < val))
 		return 0;
-	}
 
 	if (panic_later)
 		return 0;

Re: [PATCH] param: don't complain about unused module parameters.

[Jon Masters]

On Tue, 2009-12-01 at 14:56 +1030, Rusty Russell wrote:
> Jon confirms that recent modprobe will look in /proc/cmdline, so these
> cmdline options can still be used.

Yup. Thanks for that.

Jon.

Re: [PATCH] param: don't complain about unused module parameters.

[Adam Williamson]

On Tue, 2009-12-01 at 14:56 +1030, Rusty Russell wrote:
> Jon confirms that recent modprobe will look in /proc/cmdline, so these
> cmdline options can still be used.
> 
> See http://bugzilla.kernel.org/show_bug.cgi?id=14164

Thanks for the fix, Rusty. This'll save a lot of confusion :)

-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org
http://www.happyassassin.net