public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Wang Liming <liming.wang@windriver.com>
Cc: mingo@redhat.com, peterz@infradead.org, mhiramat@redhat.com,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	jbaron@redhat.com, fche@redhat.com, jkenisto@us.ibm.com,
	hch@infradead.org, ananth@in.ibm.com, srikar@linux.vnet.ibm.com,
	prasad@linux.vnet.ibm.com
Subject: Re: [tip:perf/core] perf probe: Add argv_split() from lib/argv_split.c
Date: Wed, 2 Dec 2009 06:51:21 +0100	[thread overview]
Message-ID: <20091202055119.GA5719@nowhere> (raw)
In-Reply-To: <4B15FED8.2080108@windriver.com>

On Wed, Dec 02, 2009 at 01:44:56PM +0800, Wang Liming wrote:
> When I compiled "perf", I encountered following error:
>
>     CC util/string.o
> cc1: warnings being treated as errors
> util/string.c: In function 'argv_split':
> util/string.c:216: warning: implicit declaration of function 'strndup'
> util/string.c:216: warning: incompatible implicit declaration of built-in 
> function 'strndup'
> make: *** [util/string.o] Error 1
>
> Do we need to define _GNU_SOURCE in the head? Or maybe I used rather old 
> glibc version.
>
> diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c
> index 0977cf4..ea3eb39 100644
> --- a/tools/perf/util/string.c
> +++ b/tools/perf/util/string.c
> @@ -1,5 +1,8 @@
> +#define _GNU_SOURCE
>  #include <string.h>
>  #include <stdlib.h>
> +
> +#undef _GNU_SOURCE
>  #include "string.h"
>  #include "util.h"



Right, strndup is a GNU extension.
Could you please resend this patch with your signed-off-by
and a proper changelog?

Thanks!

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>


  reply	other threads:[~2009-12-02  5:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01  0:19 [PATCH -tip 0/9] perf-probe updates Masami Hiramatsu
2009-12-01  0:19 ` [PATCH -tip 1/9] trace_kprobes: Fix a memory leak bug and check kstrdup return value Masami Hiramatsu
2009-12-01  7:31   ` [tip:perf/core] trace_kprobes: Fix a memory leak bug and check kstrdup() " tip-bot for Masami Hiramatsu
2009-12-01  0:19 ` [PATCH -tip 2/9] perf probe: Fix to change a debugging message from pr_info to pr_debug Masami Hiramatsu
2009-12-01  7:31   ` [tip:perf/core] perf probe: Change " tip-bot for Masami Hiramatsu
2009-12-01  0:19 ` [PATCH -tip 3/9] perf probe: Fix to add probe-finder.h without libdwarf Masami Hiramatsu
2009-12-01  7:31   ` [tip:perf/core] perf probe: Add " tip-bot for Masami Hiramatsu
2009-12-01  0:19 ` [PATCH -tip 4/9] perf probe: Fix argv array size in probe parser Masami Hiramatsu
2009-12-01  7:32   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01  0:19 ` [PATCH -tip 5/9] perf probe: Fix probe array index for multiple probe point Masami Hiramatsu
2009-12-01  7:32   ` [tip:perf/core] perf probe: Fix probe array index for multiple probe points tip-bot for Masami Hiramatsu
2009-12-01  0:19 ` [PATCH -tip 6/9] perf probe: Move probe event utility functions to probe-event.c Masami Hiramatsu
2009-12-01  7:32   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01  0:20 ` [PATCH -tip 7/9] perf probe: Add argv_split() from lib/argv_split.c Masami Hiramatsu
2009-12-01  7:32   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-02  5:44     ` Wang Liming
2009-12-02  5:51       ` Frederic Weisbecker [this message]
2009-12-01  0:20 ` [PATCH -tip 8/9] perf probe: Add --list option for listing current probe events Masami Hiramatsu
2009-12-01  7:32   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-02  4:12     ` Wang Liming
2009-12-02  4:56       ` Masami Hiramatsu
2009-12-02  5:35         ` Wang Liming
2009-12-02  6:06           ` Frederic Weisbecker
2009-12-02  6:21             ` Wang Liming
2009-12-02  8:31             ` Ingo Molnar
2009-12-02  8:42               ` [PATCH] perf tools: replace %m with %a in sscanf Liming Wang
2009-12-02 10:44                 ` [tip:perf/core] perf tools: Replace " tip-bot for Liming Wang
2009-12-02 16:45                 ` [PATCH] perf tools: replace " Masami Hiramatsu
2009-12-01  0:20 ` [PATCH -tip 9/9] perf probe: Simplify event naming Masami Hiramatsu
2009-12-01  7:33   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2009-12-01  7:29 ` [PATCH -tip 0/9] perf-probe updates Ingo Molnar
2009-12-02 21:53   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091202055119.GA5719@nowhere \
    --to=fweisbec@gmail.com \
    --cc=ananth@in.ibm.com \
    --cc=fche@redhat.com \
    --cc=hch@infradead.org \
    --cc=jbaron@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=liming.wang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=prasad@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox