From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trace_output: change struct trace_seq's size to PAGE_SIZE
Date: Wed, 2 Dec 2009 07:14:24 +0100 [thread overview]
Message-ID: <20091202061423.GC5719@nowhere> (raw)
In-Reply-To: <4B10E1F0.80202@cn.fujitsu.com>
On Sat, Nov 28, 2009 at 04:40:16PM +0800, Lai Jiangshan wrote:
>
> It's not very good that we allocate pages with page_order > 1.
> So we change struct trace_seq's size to PAGE_SIZE.
>
> Where we allocate a struct trace_seq:
>
> kernel/trace/trace.c:3720: s = kmalloc(sizeof(*s), GFP_KERNEL);
> kernel/trace/trace_events.c:539: s = kmalloc(sizeof(*s), GFP_KERNEL);
> kernel/trace/trace_events.c:580: s = kmalloc(sizeof(*s), GFP_KERNEL);
> kernel/trace/trace_events.c:604: s = kmalloc(sizeof(*s), GFP_KERNEL);
> kernel/trace/trace_events.c:660: s = kmalloc(sizeof(*s), GFP_KERNEL);
> kernel/trace/trace_events.c:715: s = kmalloc(sizeof(*s), GFP_KERNEL);
> kernel/trace/trace_ksym.c:230: s = kmalloc(sizeof(*s), GFP_KERNEL);
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Looks good to me.
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Steve, any objection?
prev parent reply other threads:[~2009-12-02 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 8:40 [PATCH] trace_output: change struct trace_seq's size to PAGE_SIZE Lai Jiangshan
2009-12-02 6:14 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202061423.GC5719@nowhere \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox