From: Randy Dunlap <randy.dunlap@oracle.com>
To: Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: eric.piel@tremplin-utc.net, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH v4 5/5] LIS3: Update documentation to match latest changes
Date: Wed, 2 Dec 2009 09:40:59 -0800 [thread overview]
Message-ID: <20091202094059.9cec6e27.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1259656422-7697-6-git-send-email-samu.p.onkalo@nokia.com>
On Tue, 1 Dec 2009 10:33:42 +0200 Samu Onkalo wrote:
> Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
> Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> ---
> Documentation/hwmon/lis3lv02d | 31 ++++++++++++++++++++++++-------
> 1 files changed, 24 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/hwmon/lis3lv02d b/Documentation/hwmon/lis3lv02d
> index 21f0902..cd354e3 100644
> --- a/Documentation/hwmon/lis3lv02d
> +++ b/Documentation/hwmon/lis3lv02d
> @@ -20,18 +20,35 @@ sporting the feature officially called "HP Mobile Data Protection System 3D" or
>
> This driver also provides an absolute input class device, allowing
> -the laptop to act as a pinball machine-esque joystick.
> +the laptop to act as a pinball machine-esque joystick. Joystick device can be
> +calibrated. Joystick device can be in two different modes.
> +By default output values are scaled between -32768 .. 32767. In joystick raw
> +mode, joystick and sysfs position entry have the same scale. There can be
> +small difference due to input system fuzziness feature.
> +Events are also available as input event device.
> +
> +Selftest is meant only for hardware diagnostic purposes. It is not meant to be
> +used during normal operations. Position data is not corrupted during selftest
> +but interrupt behaviour is not quaranteed to work reliably. In test mode, the
guaranteed
Otherwise looks good. Thanks.
> +sensing element is internally moved little bit. Selftest measures difference
> +between normal mode and test mode. Chip specifications tell the acceptance
> +limit for each type of the chip. Limits are provided via platform data
> +to allow adjustment of the limits without a change to the actual driver.
> +Seltest returns either "OK x y z" or "FAIL x y z" where x, y and z are
> +measured difference between modes. Axes are not remapped in selftest mode.
> +Measurement values are provided to help HW diagnostic applications to make
> +final decision.
>
> On HP laptops, if the led infrastructure is activated, support for a led
> indicating disk protection will be provided as /sys/class/leds/hp::hddprotect.
---
~Randy
next prev parent reply other threads:[~2009-12-02 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 8:33 [PATCH v4 0/5] LIS3 feature update Samu Onkalo
2009-12-01 8:33 ` [PATCH v4 1/5] lis3: Selftest support Samu Onkalo
2009-12-01 8:33 ` [PATCH v4 2/5] LIS3LV02D: Remove calibaration functionality Samu Onkalo
2009-12-01 8:33 ` [PATCH v4 3/5] lis3: Sysfs entry for setting chip measurement rate Samu Onkalo
2009-12-01 8:33 ` [PATCH v4 4/5] lis3: Scale output values to mg Samu Onkalo
2009-12-01 8:33 ` [PATCH v4 5/5] LIS3: Update documentation to match latest changes Samu Onkalo
2009-12-02 17:40 ` Randy Dunlap [this message]
2009-12-01 8:53 ` [PATCH v4 4/5] lis3: Scale output values to mg Éric Piel
2009-12-01 8:53 ` [PATCH v4 1/5] lis3: Selftest support Éric Piel
2009-12-01 8:55 ` [PATCH v4 0/5] LIS3 feature update Éric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202094059.9cec6e27.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=eric.piel@tremplin-utc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox