From: Stephen Hemminger <shemminger@vyatta.com>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: Re: [PATCH 00/13] drivers/block/floppy.c: More cleanups
Date: Wed, 2 Dec 2009 11:03:26 -0800 [thread overview]
Message-ID: <20091202110326.2a48e5e4@nehalam> (raw)
In-Reply-To: <cover.1259733456.git.joe@perches.com>
On Tue, 1 Dec 2009 22:07:40 -0800
Joe Perches <joe@perches.com> wrote:
> Might as well make it cleaner...
>
> Joe Perches (13):
> drivers/block/floppy.c: Remove macro LOCK_FDC
> drivers/block/floppy.c: Add debug_dcl(...) macro
> drivers/block/floppy.c: Remove [U]CLEARF, [U]SETF, and [U]TESTF macros
> drivers/block/floppy.c: Remove most uses of CALL and ECALL macros
> drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT and ECALL macros
> drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT
> drivers/block/floppy.c: convert int 1/0 to bool true/false
> drivers/block/floppy.c: Move leading && and || to preceding line
> drivers/block/floppy.c: remove #define DEVICE_NAME "floppy"
> drivers/block/floppy.c: Convert int initialising to bool initialized
> drivers/block/floppy.c: Add function is_ready_state
> drivers/block/floppy.c: Readd SunOS eject cmd comment
> drivers/block/floppy.c: Remove unnecessary return and braces
>
> drivers/block/floppy.c | 410 ++++++++++++++++++++++++------------------------
> 1 files changed, 208 insertions(+), 202 deletions(-)
>
I like seeing it as individual patches like this, but the first batch
starts after your huge patch. Why not split that one up as well.
--
next prev parent reply other threads:[~2009-12-02 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 6:07 [PATCH 00/13] drivers/block/floppy.c: More cleanups Joe Perches
2009-12-02 6:07 ` [PATCH 01/13] drivers/block/floppy.c: Remove macro LOCK_FDC Joe Perches
2009-12-02 6:07 ` [PATCH 02/13] drivers/block/floppy.c: Add debug_dcl(...) macro Joe Perches
2009-12-02 6:07 ` [PATCH 03/13] drivers/block/floppy.c: Remove [U]CLEARF, [U]SETF, and [U]TESTF macros Joe Perches
2009-12-02 6:07 ` [PATCH 04/13] drivers/block/floppy.c: Remove most uses of CALL and ECALL macros Joe Perches
2009-12-02 6:07 ` [PATCH 05/13] drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT " Joe Perches
2009-12-02 6:07 ` [PATCH 06/13] drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT Joe Perches
2009-12-02 6:07 ` [PATCH 07/13] drivers/block/floppy.c: convert int 1/0 to bool true/false Joe Perches
2009-12-02 6:07 ` [PATCH 08/13] drivers/block/floppy.c: Move leading && and || to preceding line Joe Perches
2009-12-02 6:07 ` [PATCH 09/13] drivers/block/floppy.c: remove #define DEVICE_NAME "floppy" Joe Perches
2009-12-02 6:07 ` [PATCH 10/13] drivers/block/floppy.c: Convert int initialising to bool initialized Joe Perches
2009-12-02 6:07 ` [PATCH 11/13] drivers/block/floppy.c: Add function is_ready_state Joe Perches
2009-12-02 6:07 ` [PATCH 12/13] drivers/block/floppy.c: Readd SunOS eject cmd comment Joe Perches
2009-12-02 6:07 ` [PATCH 13/13] drivers/block/floppy.c: Remove unnecessary return and braces Joe Perches
2009-12-02 17:05 ` [PATCH 00/13] drivers/block/floppy.c: More cleanups Marcin Slusarz
2009-12-02 19:03 ` Stephen Hemminger [this message]
2009-12-02 20:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202110326.2a48e5e4@nehalam \
--to=shemminger@vyatta.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox