* [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init()
@ 2009-12-01 22:12 Veaceslav Falico
2009-12-02 14:05 ` Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Veaceslav Falico @ 2009-12-01 22:12 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Al Viro, Miloslav Trmac, James Morris,
Alan Cox, Ingo Molnar, Peter Zijlstra, Andrew Morton,
Balbir Singh, Alexey Dobriyan, Heiko Carstens, Renaud Lottiaux,
Louis Rilling, David Howells, Oleg Nesterov
Remove unneeded initializations in acct_init_pacct() and taskstats_tgid_init().
These are accessed only via copy_signal().
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
diff --git a/include/linux/taskstats_kern.h b/include/linux/taskstats_kern.h
index 3398f45..d66167a 100644
--- a/include/linux/taskstats_kern.h
+++ b/include/linux/taskstats_kern.h
@@ -16,7 +16,6 @@ extern struct mutex taskstats_exit_mutex;
static inline void taskstats_tgid_init(struct signal_struct *sig)
{
- sig->stats = NULL;
}
static inline void taskstats_tgid_free(struct signal_struct *sig)
diff --git a/kernel/acct.c b/kernel/acct.c
index 9a4715a..8909c26 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -592,8 +592,6 @@ out:
*/
void acct_init_pacct(struct pacct_struct *pacct)
{
- memset(pacct, 0, sizeof(struct pacct_struct));
- pacct->ac_utime = pacct->ac_stime = cputime_zero;
}
/**
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init()
2009-12-01 22:12 [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init() Veaceslav Falico
@ 2009-12-02 14:05 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2009-12-02 14:05 UTC (permalink / raw)
To: Veaceslav Falico
Cc: linux-kernel, Greg Kroah-Hartman, Al Viro, Miloslav Trmac,
James Morris, Alan Cox, Ingo Molnar, Peter Zijlstra,
Andrew Morton, Balbir Singh, Alexey Dobriyan, Heiko Carstens,
Renaud Lottiaux, Louis Rilling, David Howells
On 12/01, Veaceslav Falico wrote:
>
> Remove unneeded initializations in acct_init_pacct() and taskstats_tgid_init().
> These are accessed only via copy_signal().
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
> ---
>
> diff --git a/include/linux/taskstats_kern.h b/include/linux/taskstats_kern.h
> index 3398f45..d66167a 100644
> --- a/include/linux/taskstats_kern.h
> +++ b/include/linux/taskstats_kern.h
> @@ -16,7 +16,6 @@ extern struct mutex taskstats_exit_mutex;
>
> static inline void taskstats_tgid_init(struct signal_struct *sig)
> {
> - sig->stats = NULL;
> }
>
> static inline void taskstats_tgid_free(struct signal_struct *sig)
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 9a4715a..8909c26 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -592,8 +592,6 @@ out:
> */
> void acct_init_pacct(struct pacct_struct *pacct)
> {
> - memset(pacct, 0, sizeof(struct pacct_struct));
> - pacct->ac_utime = pacct->ac_stime = cputime_zero;
> }
Looks good imho. But please note that with this patch both
taskstats_tgid_init() and acct_init_pacct() become empty, and we
already have "empty" definitions for #ifndef case.
Perhaps it makes sense to move this (now empty) helper outside
of #ifdef, or just kill it.
Up to maintainres.
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-02 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 22:12 [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init() Veaceslav Falico
2009-12-02 14:05 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox