* [PATCH 4/4] copy_signal cleanup: clean tty_audit_fork()
@ 2009-12-01 22:13 Veaceslav Falico
2009-12-02 14:15 ` Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Veaceslav Falico @ 2009-12-01 22:13 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Al Viro, Miloslav Trmac, James Morris,
Alan Cox, Ingo Molnar, Peter Zijlstra, Andrew Morton,
Balbir Singh, Alexey Dobriyan, Heiko Carstens, Renaud Lottiaux,
Louis Rilling, David Howells, Oleg Nesterov
Remove unneeded initialization in tty_audit_fork().
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
diff --git a/drivers/char/tty_audit.c b/drivers/char/tty_audit.c
index ac16fbe..283a15b 100644
--- a/drivers/char/tty_audit.c
+++ b/drivers/char/tty_audit.c
@@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig)
spin_lock_irq(¤t->sighand->siglock);
sig->audit_tty = current->signal->audit_tty;
spin_unlock_irq(¤t->sighand->siglock);
- sig->tty_audit_buf = NULL;
}
/**
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] copy_signal cleanup: clean tty_audit_fork()
2009-12-01 22:13 [PATCH 4/4] copy_signal cleanup: clean tty_audit_fork() Veaceslav Falico
@ 2009-12-02 14:15 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2009-12-02 14:15 UTC (permalink / raw)
To: Veaceslav Falico
Cc: linux-kernel, Greg Kroah-Hartman, Al Viro, Miloslav Trmac,
James Morris, Alan Cox, Ingo Molnar, Peter Zijlstra,
Andrew Morton, Balbir Singh, Alexey Dobriyan, Heiko Carstens,
Renaud Lottiaux, Louis Rilling, David Howells
On 12/01, Veaceslav Falico wrote:
>
> Remove unneeded initialization in tty_audit_fork().
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
> ---
>
> diff --git a/drivers/char/tty_audit.c b/drivers/char/tty_audit.c
> index ac16fbe..283a15b 100644
> --- a/drivers/char/tty_audit.c
> +++ b/drivers/char/tty_audit.c
> @@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig)
> spin_lock_irq(¤t->sighand->siglock);
> sig->audit_tty = current->signal->audit_tty;
> spin_unlock_irq(¤t->sighand->siglock);
> - sig->tty_audit_buf = NULL;
> }
OK, but given that this function is "far" from copy_signal() path
and it is not inline, perhaps it makes sense to add the comment which
explains *sig must be zeroed, and the only caller is copy_signal().
Hmm. Off-topic, but why do we take ->siglock? ->audit_tty is boolean,
afaics ->siglock buys nothing.
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-02 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 22:13 [PATCH 4/4] copy_signal cleanup: clean tty_audit_fork() Veaceslav Falico
2009-12-02 14:15 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox